Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reconcile service binding resource between openapi versions #742

Merged
merged 2 commits into from
Jun 22, 2021
Merged

Reconcile service binding resource between openapi versions #742

merged 2 commits into from
Jun 22, 2021

Conversation

WalkerGriggs
Copy link
Contributor

What is the problem this PR solves?

Adds missing endpoint object and properties to the swagger.yaml service binding resource / response.

Fixes: #741

Checklist:

  • The swagger.yaml doc has been updated with any required changes
  • The openapi.yaml doc has been updated with any required changes

@Samze Samze self-requested a review June 22, 2021 15:50
Samze
Samze approved these changes Jun 22, 2021
View reviewed changes
Copy link
Contributor

@Samze Samze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Samze Samze merged commit c619d71 into openservicebrokerapi:master Jun 22, 2021
@WalkerGriggs WalkerGriggs mentioned this pull request Jun 29, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avilupu avilupu avilupu approved these changes

@Samze Samze Samze approved these changes

@rsampaio rsampaio rsampaio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Swagger spec is missing service binding endpoint object + properties
4 participants
@WalkerGriggs @rsampaio @Samze @avilupu