Enable run maps tests when security enabled #1044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junqiu-lei
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
maps_tests_with_security
branch
from
a68f748 to
cee038b
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
junqiu-lei
force-pushed
the
maps_tests_with_security
branch
from
cee038b to
28a734b
Compare
Signed-off-by: Junqiu Lei <junqiu@amazon.com>
|
After I changed browser to electron, all tests can passed now. I think it was due to overloaded capacity within chrome/chromium that caused the CI failure, which also happened in dashboard-maps CI. opensearch-project/dashboards-maps#572 (comment) |
ruanyl
approved these changes
Feb 2, 2024
|
@junqiu-lei should this fix also merged to |
Yes, will raise another PR to main since there are some code differences between main and 2.x |
wanglam
approved these changes
Feb 2, 2024
raintygao
approved these changes
Feb 2, 2024
Swiddis
pushed a commit
to Swiddis/opensearch-dashboards-functional-test
that referenced
this pull request
Feb 2, 2024
* Enable run maps tests when security enabled Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Fix test order by adding files name with number Signed-off-by: Junqiu Lei <junqiu@amazon.com> * Update maps-dashboards CI workflow Signed-off-by: Junqiu Lei <junqiu@amazon.com> --------- Signed-off-by: Junqiu Lei <junqiu@amazon.com> Signed-off-by: Simeon Widdis <sawiddis@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable run maps tests when security enabled
Issues Resolved
#883
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.