Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[navigation]feat: update category to flatten menus in analytics(all) use case #448

Merged
merged 3 commits into from
Sep 30, 2024
Merged

[navigation]feat: update category to flatten menus in analytics(all) use case #448

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0981685
feat: update category
SuZhou-Joe Sep 26, 2024
adf9404
Bump upload artifact version
derek-ho Sep 26, 2024
83c609f
Merge branch 'main' of github.com:opensearch-project/dashboards-repor…
derek-ho Sep 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/cypress-e2e-reporting-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,14 +154,14 @@ jobs:
working-directory: OpenSearch-Dashboards/plugins/${{ env.PLUGIN_NAME }}

- name: Capture failure screenshots
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4.4.0
if: failure()
with:
name: cypress-screenshots-${{ matrix.os }}
path: OpenSearch-Dashboards/plugins/${{ env.PLUGIN_NAME }}/.cypress/screenshots

- name: Capture test video
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4.4.0
if: failure()
with:
name: cypress-videos-${{ matrix.os }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/dashboards-reports-test-and-build-workflow.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ jobs:
whoami && yarn build && mv -v ./build/*.zip ./build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip"

- name: Upload Artifact For Linux
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4.4.0
with:
name: dashboards-reports-linux
path: ./OpenSearch-Dashboards/plugins/${{ env.PLUGIN_NAME }}/build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip
Expand Down Expand Up @@ -129,7 +129,7 @@ jobs:


- name: Upload Artifact For Windows
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4.4.0
with:
name: dashboards-reports-windows
path: ./build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip
Expand Down Expand Up @@ -186,7 +186,7 @@ jobs:
mv ./build/*.zip ./build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip

- name: Upload Artifact For MacOS
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4.4.0
with:
name: dashboards-reports-macosx
path: ./build/${{ env.ARTIFACT_NAME }}-${{ env.OPENSEARCH_PLUGIN_VERSION }}.zip
4 changes: 2 additions & 2 deletions .github/workflows/ftr-e2e-reporting-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,14 +162,14 @@ jobs:
working-directory: opensearch-dashboards-functional-test

- name: Capture failure screenshots
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4.4.0
if: failure()
with:
name: cypress-screenshots-${{ matrix.os }}
path: opensearch-dashboards-functional-test/cypress/screenshots

- name: Capture test video
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4.4.0
if: failure()
with:
name: cypress-videos-${{ matrix.os }}
Expand Down
9 changes: 8 additions & 1 deletion public/plugin_nav.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,9 @@
import { CoreSetup } from '../../../src/core/public';
import { ReportsDashboardsPluginSetup } from './types';
import { PLUGIN_ID } from '../common';
import { DEFAULT_NAV_GROUPS, DEFAULT_APP_CATEGORIES } from '../../../src/core/public';

Check failure on line 9 in public/plugin_nav.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Replace `·DEFAULT_NAV_GROUPS,·DEFAULT_APP_CATEGORIES·` with `⏎··DEFAULT_NAV_GROUPS,⏎··DEFAULT_APP_CATEGORIES,⏎`

export function registerAllPluginNavGroups(core: CoreSetup<ReportsDashboardsPluginSetup>) {

Check failure on line 11 in public/plugin_nav.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Replace `core:·CoreSetup<ReportsDashboardsPluginSetup>` with `⏎··core:·CoreSetup<ReportsDashboardsPluginSetup>⏎`
core.chrome.navGroup.addNavLinksToGroup(DEFAULT_NAV_GROUPS.observability, [
{
id: PLUGIN_ID,
Expand All @@ -16,17 +16,24 @@
order: 300,
},
]);
core.chrome.navGroup.addNavLinksToGroup(DEFAULT_NAV_GROUPS[`security-analytics`], [

Check failure on line 19 in public/plugin_nav.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Replace `DEFAULT_NAV_GROUPS[`security-analytics`],` with `⏎····DEFAULT_NAV_GROUPS[`security-analytics`],⏎···`
{

Check failure on line 20 in public/plugin_nav.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Replace `····` with `······`
id: PLUGIN_ID,

Check failure on line 21 in public/plugin_nav.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Insert `··`
category: DEFAULT_APP_CATEGORIES.visualizeAndReport,

Check failure on line 22 in public/plugin_nav.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Insert `··`
order: 300,

Check failure on line 23 in public/plugin_nav.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Replace `······` with `········`
},

Check failure on line 24 in public/plugin_nav.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Insert `··`
]);

Check failure on line 25 in public/plugin_nav.tsx

View workflow job for this annotation

GitHub Actions / Lint 

Replace `··]` with `····]⏎··`
core.chrome.navGroup.addNavLinksToGroup(DEFAULT_NAV_GROUPS.search, [
{
id: PLUGIN_ID,
category: DEFAULT_APP_CATEGORIES.analyzeSearch,
category: DEFAULT_APP_CATEGORIES.visualizeAndReport,
order: 300,
},
]);
core.chrome.navGroup.addNavLinksToGroup(DEFAULT_NAV_GROUPS.all, [
{
id: PLUGIN_ID,
category: DEFAULT_APP_CATEGORIES.visualizeAndReport,
order: 300,
},
]);
Expand Down
Loading