[Backport 2.x] [Workspace]Remove collaborators in workspace creation page and refactor with getDisplayedType #8560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](/~https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
…or with getDisplayedType (#8520) * Remove workspace collaborators section in workspace creation Signed-off-by: Lin Wang <wonglam@amazon.com> * Redirect to workspace detail collaborators tab after workspace created Signed-off-by: Lin Wang <wonglam@amazon.com> * Changeset file for PR #8520 created/updated * Add getDisplayedType in default collaborator types Signed-off-by: Lin Wang <wonglam@amazon.com> * Update detail type to ReactNode Signed-off-by: Lin Wang <wonglam@amazon.com> * Add learn more link Signed-off-by: Lin Wang <wonglam@amazon.com> * Remove permissionEnabled passed in WorkspaceCreatorForm Signed-off-by: Lin Wang <wonglam@amazon.com> * Redirect to use case landing page if permission not enabled Signed-off-by: Lin Wang <wonglam@amazon.com> * Use getDisplayedType and render — for empty Signed-off-by: Lin Wang <wonglam@amazon.com> * Fix incorrect unit tests Signed-off-by: Lin Wang <wonglam@amazon.com> * Assign current user as workspace admin Signed-off-by: Lin Wang <wonglam@amazon.com> --------- Signed-off-by: Lin Wang <wonglam@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit fcc18fb) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi,
mengweieric,
LDrago27,
virajsanghvi,
sejli,
joshuali925 and
huyaboo
as code owners
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8560 +/- ##
=======================================
Coverage 61.03% 61.03%
=======================================
Files 3771 3771
Lines 89566 89564 -2
Branches 14017 14020 +3
=======================================
- Hits 54664 54663 -1
- Misses 31495 31496 +1
+ Partials 3407 3405 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Hailong-am
approved these changes
Oct 11, 2024
SuZhou-Joe
approved these changes
Oct 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport fcc18fb from #8520.