-
Notifications
You must be signed in to change notification settings - Fork 967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backport 2.x] [Workspace] Content menu picker in side bar and enable searching #8017
Conversation
* 01-feat/refractor-content-menu-picker-in-side-bar Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 02-enable-associated-icon Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 03-update-side-bar Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 04-fix-bugs Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 04-fix-bugs, add test Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 05-delete search Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 06-delete search Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 06-fix-bug Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 07-fix-conflication-1 Signed-off-by: Qxisylolo <qianxisy@amazon.com> * 07-fix-conflication-adjust-icon-size Signed-off-by: Qxisylolo <qianxisy@amazon.com> * Changeset file for PR #7881 created/updated --------- Signed-off-by: Qxisylolo <qianxisy@amazon.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit a05c4a2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
❌ Invalid Changelog HeadingThe '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.x #8017 +/- ##
=======================================
Coverage 60.60% 60.61%
=======================================
Files 3727 3727
Lines 88292 88304 +12
Branches 13652 13656 +4
=======================================
+ Hits 53512 53524 +12
Misses 31529 31529
Partials 3251 3251
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8017-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f29bc578aa3f52c6cb8bf31c9cd2846459236f87
# Push it to GitHub
git push --set-upstream origin backport/backport-8017-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17 Then, create a pull request where the |
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/OpenSearch-Dashboards/backport-2.17 2.17
# Navigate to the new working tree
pushd ../.worktrees/OpenSearch-Dashboards/backport-2.17
# Create a new branch
git switch --create backport/backport-8017-to-2.17
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 f29bc578aa3f52c6cb8bf31c9cd2846459236f87
# Push it to GitHub
git push --set-upstream origin backport/backport-8017-to-2.17
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/OpenSearch-Dashboards/backport-2.17 Then, create a pull request where the |
…) (#8017) * 01-feat/refractor-content-menu-picker-in-side-bar * 02-enable-associated-icon * 03-update-side-bar * 04-fix-bugs * 04-fix-bugs, add test * 05-delete search * 06-delete search * 06-fix-bug * 07-fix-conflication-1 * 07-fix-conflication-adjust-icon-size * Changeset file for PR #7881 created/updated --------- (cherry picked from commit a05c4a2) Signed-off-by: Qxisylolo <qianxisy@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com> (cherry picked from commit f29bc57) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
…) (#8017) (#8049) * 01-feat/refractor-content-menu-picker-in-side-bar * 02-enable-associated-icon * 03-update-side-bar * 04-fix-bugs * 04-fix-bugs, add test * 05-delete search * 06-delete search * 06-fix-bug * 07-fix-conflication-1 * 07-fix-conflication-adjust-icon-size * Changeset file for PR #7881 created/updated --------- (cherry picked from commit a05c4a2) (cherry picked from commit f29bc57) Signed-off-by: Qxisylolo <qianxisy@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
Backport a05c4a2 from #7881.