Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.16] [MDS] Fix the hide local cluster config #7507

Merged
merged 3 commits into from
Jul 29, 2024

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport e24e535 from #7497.

* Fix the local cluster config

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Fix the local cluster config and add test

Signed-off-by: Ryan Liang <jiallian@amazon.com>

* Changeset file for PR #7497 created/updated

---------

Signed-off-by: Ryan Liang <jiallian@amazon.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>
(cherry picked from commit e24e535)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link
Contributor

❌ Invalid Changelog Heading

The '## Changelog' heading in your PR description is either missing or malformed. Please make sure that your PR description includes a '## Changelog' heading with proper spelling, capitalization, spacing, and Markdown syntax.

Copy link

codecov bot commented Jul 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.21%. Comparing base (e7bbab6) to head (0606ec0).

Additional details and impacted files
@@           Coverage Diff           @@
##             2.16    #7507   +/-   ##
=======================================
  Coverage   64.21%   64.21%           
=======================================
  Files        3614     3614           
  Lines       78750    78750           
  Branches    12446    12446           
=======================================
+ Hits        50567    50569    +2     
  Misses      25131    25131           
+ Partials     3052     3050    -2     
Flag Coverage Δ
Linux_1 30.92% <ø> (ø)
Linux_2 55.71% <ø> (ø)
Linux_3 40.69% <ø> (+<0.01%) ⬆️
Linux_4 31.90% <ø> (ø)
Windows_1 30.93% <ø> (ø)
Windows_2 55.66% <ø> (ø)
Windows_3 40.69% <ø> (+<0.01%) ⬆️
Windows_4 31.90% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RyanL1997
Copy link
Contributor

the failing test is:

  │ ✖  core-opensearch-dashboards/opensear      05:47       24       21        1        2        - │
  │    ch-dashboards/apps/data_explorer/di                                                         │
  │    scover_table.spec.js   

and it seems like it is not related to the change, and we may need a re-run

@RyanL1997
Copy link
Contributor

right now im seeing the bootstrap failures:

ERROR [bootstrap] failed:
ERROR Error: Command failed with exit code 1: babel src --no-babelrc --presets @osd/babel-preset/webpack_preset --out-dir /__w/OpenSearch-Dashboards/OpenSearch-Dashboards/packages/osd-std/target/web --extensions .ts,.js,.tsx --ignore **/*.test.ts,**/*.test.tsx --quiet --source-maps inline
          at makeError (/__w/OpenSearch-Dashboards/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:27391:11)
          at handlePromise (/__w/OpenSearch-Dashboards/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:26327:26)
          at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
          at async Promise.all (index 0)
          at async buildTargetedPackage (/__w/OpenSearch-Dashboards/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:29429:3)
          at async /__w/OpenSearch-Dashboards/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:9139:11
          at async scheduleItem (/__w/OpenSearch-Dashboards/OpenSearch-Dashboards/packages/osd-pm/dist/index.js:11198:9)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

@zhyuanqi zhyuanqi merged commit 36f1a1d into 2.16 Jul 29, 2024
64 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autocut Skip the changelog verification check on backports failed changeset valued-contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants