Add missing change log for 2.15 MDS PRs #6986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongnansu
requested review from
ananzh,
kavilla,
AMoo-Miki,
ashwin-pc,
joshuarrrr,
abbyhu2000,
zengyan-amazon,
manasvinibs,
ZilongX,
Flyingliuhub,
curq,
bandinib-amzn,
SuZhou-Joe,
ruanyl,
BionIT,
xinruiba,
zhyuanqi and
mengweieric
as code owners
❌ Empty Changelog SectionThe Changelog section in your PR description is empty. Please add a valid changelog entry or entries. If you did add a changelog entry, check to make sure that it was not accidentally included inside the comment block in the Changelog section. |
github-actions
bot
added
the
Skip-Changelog
AMoo-Miki
reviewed
Jun 10, 2024
changelogs/fragments/6919.yml
Outdated
| @@ -0,0 +1,2 @@ | |||
| feat: | |||
| - Modify the adding sample data part for timeline ([#6919](/~https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6919)) | |||
There was a problem hiding this comment.
The entry should describe the outcome not what was done.
There was a problem hiding this comment.
Thanks Miki. How about "Enable the addition of sample data for timeline visualizations with MDS enabled. "
AMoo-Miki
reviewed
Jun 10, 2024
AMoo-Miki
reviewed
Jun 10, 2024
changelogs/fragments/6385.yml
Outdated
| @@ -0,0 +1,2 @@ | |||
| feat: | |||
| - [MDS] Support for Timeline ([#6385](/~https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6385)) | |||
There was a problem hiding this comment.
While this is nice and short, it is not clear enough what impact users should expect.
zhongnansu
force-pushed
the
mds-missing-notes
branch
from
fd71629 to
3b0db8a
Compare
zhyuanqi
previously approved these changes
Jun 10, 2024
AMoo-Miki
reviewed
Jun 10, 2024
changelogs/fragments/6385.yml
Outdated
| @@ -0,0 +1,2 @@ | |||
| feat: | |||
| - [MDS] Enable user to query from data source in Timeline ([#6385](/~https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6385)) | |||
There was a problem hiding this comment.
Suggested change
| - [MDS] Enable user to query from data source in Timeline ([#6385](/~https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6385)) | |
| - [MDS] Allow querying from data sources in Timeline visualizations ([#6385](/~https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6385)) |
AMoo-Miki
reviewed
Jun 10, 2024
changelogs/fragments/6919.yml
Outdated
| @@ -0,0 +1,2 @@ | |||
| feat: | |||
| - [MDS] Enable the addition of sample data for timeline visualizations with MDS enabled ([#6919](/~https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6919)) | |||
There was a problem hiding this comment.
Suggested change
| - [MDS] Enable the addition of sample data for timeline visualizations with MDS enabled ([#6919](/~https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6919)) | |
| - [MDS] Allow adding sample data for Timeline visualizations ([#6919](/~https://github.com/opensearch-project/OpenSearch-Dashboards/pull/6919)) |
|
Thanks @zhongnansu and @zhyuanqi |
Signed-off-by: Zhongnan Su <szhongna@amazon.com>
zhongnansu
force-pushed
the
mds-missing-notes
branch
from
3b0db8a to
8193ec0
Compare
Thanks for the suggestions! @AMoo-Miki |
zhyuanqi
approved these changes
Jun 10, 2024
BionIT
approved these changes
Jun 10, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit b2786b2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhongnansu
pushed a commit
that referenced
this pull request
Jun 10, 2024
Signed-off-by: Zhongnan Su <szhongna@amazon.com> (cherry picked from commit b2786b2) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
zhyuanqi
pushed a commit
that referenced
this pull request
Jun 10, 2024
(cherry picked from commit b2786b2) Signed-off-by: Zhongnan Su <szhongna@amazon.com> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
l0rdn1kk0n
pushed a commit
to l0rdn1kk0n/OpenSearch-Dashboards
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Zhongnan Su <szhongna@amazon.com> Signed-off-by: Michael Haitz <admin@doridina.de>
l0rdn1kk0n
pushed a commit
to l0rdn1kk0n/OpenSearch-Dashboards
that referenced
this pull request
Jun 11, 2024
Signed-off-by: Zhongnan Su <szhongna@amazon.com> Signed-off-by: Michael Haitz <admin@doridina.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding missing change log for the following PRs:
#6395
#6919
#6385
Issues Resolved
Screenshot
Testing the changes
Changelog
Check List
yarn test:jestyarn test:jest_integration