[Backport 2.x] Fix (styles): Make ace code editor themes consistent #4616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![opensearch-trigger-bot[bot]](/~https://avatars.githubusercontent.com/u/80134844?s=60&v=4){kind=small}
* Fix (styles): Make ace code editor themes consistent Use "textmate" theme everywhere Update override selector to apply to root, to style portaled components, too (such as filter editor) Signed-off-by: Josh Romero <rmerqg@amazon.com> * add changelog Signed-off-by: Josh Romero <rmerqg@amazon.com> --------- Signed-off-by: Josh Romero <rmerqg@amazon.com> (cherry picked from commit f8ad83f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> # Conflicts: # CHANGELOG.md
opensearch-trigger-bot
bot
requested review from
ananzh,
kavilla,
seanneumann,
AMoo-Miki,
ashwin-pc,
joshuarrrr and
abbyhu2000
as code owners
opensearch-trigger-bot
bot
added
autocut
opensearch-trigger-bot
bot
requested a review
from zengyan-amazon
as a code owner
opensearch-trigger-bot
bot
requested review from
kristenTian,
zhongnansu,
manasvinibs,
ZilongX,
Flyingliuhub and
BSFishy
as code owners
Codecov Report
@@ Coverage Diff @@
## 2.x #4616 +/- ##
==========================================
- Coverage 66.17% 66.16% -0.01%
==========================================
Files 3315 3315
Lines 63891 63891
Branches 9966 9966
==========================================
- Hits 42278 42276 -2
+ Misses 19248 19172 -76
- Partials 2365 2443 +78
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joshuarrrr
approved these changes
Jul 25, 2023
abbyhu2000
approved these changes
Jul 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport f8ad83f from #4609.