Revert "Updates NOTICE file, adds validation to GitHub CI (#3051)" #3204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
manasvinibs
previously approved these changes
Jan 6, 2023
manasvinibs
added
backport 2.x
v2.5.0
abbyhu2000
previously approved these changes
Jan 6, 2023
Codecov Report
@@ Coverage Diff @@
## main #3204 +/- ##
==========================================
- Coverage 66.56% 66.50% -0.06%
==========================================
Files 3203 3203
Lines 61322 61327 +5
Branches 9452 9452
==========================================
- Hits 40818 40785 -33
- Misses 18223 18281 +58
+ Partials 2281 2261 -20
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
…-project#3051)" This reverts commit 100a41a. Reverting for further investigating year range in notice header. Signed-off-by: Josh Romero <rmerqg@amazon.com>
manasvinibs
force-pushed
the
revert/3051
branch
from
02a1696 to
c1a3556
Compare
joshuarrrr
dismissed stale reviews from abbyhu2000 and manasvinibs
via
c1a3556
|
Will we be re-doing this with the correct date? |
kavilla
approved these changes
Jan 18, 2023
Yeah, I think we'll want to. I re-opened the issue for tracking: #765 |
|
If you want to leave this, here's the fix: #3308 |
|
will merge in the date fix #3308 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This reverts commit 100a41a.
Reverting for further investigating year range in notice header: #3177 (comment)
Issues Resolved
N/A
Check List
yarn test:jestyarn test:jest_integrationyarn test:ftr