[Look&Feel] Consistency of Plus Icons (#7195)

* Updated plus icon over plusInCircle for add/create use cases.

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Added plus icon to dashboard creation.

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Reverted Dashboard Creation Icon

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Changeset file for PR #7195 created/updated

* Revert plus icon changes for add use cases

Signed-off-by: Dan Dong <danieldong51@gmail.com>

* Fixed snapshot testing

Signed-off-by: Dan Dong <danieldong51@gmail.com>

---------

Signed-off-by: Dan Dong <danieldong51@gmail.com>
Co-authored-by: opensearch-changeset-bot[bot] <154024398+opensearch-changeset-bot[bot]@users.noreply.github.com>

changelogs/fragments/7195.yml

@@ -0,0 +1,2 @@
+refactor:
+- [Look&Feel] Consistency of Plus Icons ([#7195](/~https://github.com/opensearch-project/OpenSearch-Dashboards/pull/7195))

src/plugins/dashboard/public/application/components/dashboard_listing/create_button.tsx

@@ -78,12 +78,7 @@ const CreateButton = (props: CreateButtonProps) => {
     const provider: DashboardProvider = Object.values(props.dashboardProviders!)[0];
     return (
       <EuiFlexItem grow={false}>
-        <EuiButton
-          href={provider.createUrl}
-          data-test-subj="newItemButton"
-          iconType="plusInCircle"
-          fill
-        >
+        <EuiButton href={provider.createUrl} data-test-subj="newItemButton" iconType="plus" fill>
           <FormattedMessage id="dashboard.listing.createButtonText" defaultMessage="Create" />
           &nbsp;{provider.createLinkText}
         </EuiButton>

src/plugins/dashboard/public/application/components/dashboard_top_nav/top_nav/get_top_nav_config.ts

@@ -181,7 +181,7 @@ function getAddConfig(action: NavAction) {
 function getCreateNewConfig(action: NavAction) {
   return {
     emphasize: true,
-    iconType: 'plusInCircleFilled',
+    iconType: 'plus',
     id: 'addNew',
     label: i18n.translate('dashboard.topNave.addNewButtonAriaLabel', {
       defaultMessage: 'Create new',

src/plugins/dashboard/public/application/embeddable/empty/dashboard_empty_screen.tsx

@@ -69,7 +69,7 @@ export function DashboardEmptyScreen({
       <EuiButton
         iconSide="left"
         size="s"
-        iconType="plusInCircle"
+        iconType="plus"
         onClick={onVisualizeClick}
         data-test-subj="addVisualizationButton"
         aria-label={constants.createNewVisualizationButtonAriaLabel}

src/plugins/dashboard/public/application/utils/get_no_items_message.tsx

@@ -80,7 +80,7 @@ export const getNoItemsMessage = (
         <EuiButton
           onClick={createItem}
           fill
-          iconType="plusInCircle"
+          iconType="plus"
           data-test-subj="createDashboardPromptButton"
         >
           <FormattedMessage

src/plugins/embeddable/public/lib/panel/panel_header/panel_actions/add_panel/saved_object_finder_create_new.tsx

@@ -52,7 +52,7 @@ export function SavedObjectFinderCreateNew({ menuItems }: Props) {
       button={
         <EuiButton
           data-test-subj="createNew"
-          iconType="plusInCircle"
+          iconType="plus"
           iconSide="left"
           onClick={toggleCreateMenu}
           fill

src/plugins/index_pattern_management/public/components/create_button/create_button.tsx

@@ -76,7 +76,7 @@ export class CreateButton extends Component<Props, State> {
           data-test-subj="createIndexPatternButton"
           fill={true}
           onClick={options[0].onClick}
-          iconType="plusInCircle"
+          iconType="plus"
         >
           {children}
         </EuiButton>

src/plugins/opensearch_dashboards_react/public/table_list_view/table_list_view.tsx

@@ -505,7 +505,7 @@ class TableListView extends React.Component<TableListViewProps, TableListViewSta
         <EuiButton
           onClick={this.props.createItem}
           data-test-subj="newItemButton"
-          iconType="plusInCircle"
+          iconType="plus"
           fill
         >
           <FormattedMessage

src/plugins/vis_default_editor/public/components/controls/date_ranges.tsx

@@ -229,7 +229,7 @@ function DateRangesParamEditor({
         <EuiSpacer size="s" />
         <EuiFlexItem>
           <EuiButtonEmpty
-            iconType="plusInCircleFilled"
+            iconType="plus"
             onClick={onAddRange}
             size="xs"
             data-test-subj="visEditorAddDateRange"

src/plugins/visualize/public/application/utils/get_table_columns.tsx

@@ -198,7 +198,7 @@ export const getNoItemsMessage = (createItem: () => void) => (
       <EuiButton
         onClick={createItem}
         fill
-        iconType="plusInCircle"
+        iconType="plus"
         data-test-subj="createVisualizationPromptButton"
       >
         <FormattedMessage