Java 11 recipe for default keystore change #667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](/~https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
src/test/java/org/openrewrite/java/migrate/ChangeDefaultKeyStoreTest.java
Show resolved
Hide resolved
src/test/java/org/openrewrite/java/migrate/ChangeDefaultKeyStoreTest.java
Show resolved
Hide resolved
timtebeek
reviewed
Jan 27, 2025
|
|
||
| @Override | ||
| public TreeVisitor<?, ExecutionContext> getVisitor() { | ||
| return new JavaVisitor<ExecutionContext>() { |
There was a problem hiding this comment.
Sounds like we'll want to add a precondition here on (exclusively) using an older Java version before applying any changes here.
There was a problem hiding this comment.
Hi @timtebeek i added a Percondition.check() to the code and updated the test as well.
|
As a quick FYI: I'm out this week, but my colleagues will step in for a review. |
src/test/java/org/openrewrite/java/migrate/ChangeDefaultKeyStoreTest.java
Outdated
Show resolved
Hide resolved
|
@timtebeek can you assign the review to someone else? I fixed the PR based on your comments |
|
Will have a look soon |
|
Hi @MBoegers let me know if you had any feedback on this PR. Thanks! |
…yStore#getDefaultType()`
|
sorry, excuse the delay.. I added 2 positive tests and will merge. |
MBoegers
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's changed?
recipe: org.openrewrite.java.migrate.ChangeDefaultKeyStore in Java11
What's your motivation?
This recipe returns
jkswhen Keystore.getDefaultType() is calledAnyone you would like to review specifically?
@timtebeek
Checklist