optimize: add Installation section in README.markdown, add warning message under the install target #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynch1981
changed the title
lynch1981
changed the title
lynch1981
changed the title
zhuizhuhaomeng
previously approved these changes
Jan 22, 2024
|
This is not a good idea. |
got it |
lynch1981
changed the title
|
The Installation part is missing in README.markdown, please review the section I added @zhuizhuhaomeng |
zhuizhuhaomeng
requested changes
Jan 22, 2024
Makefile
Outdated
| PREFIX ?= /usr/local | ||
| LUA_INCLUDE_DIR ?= $(PREFIX)/include | ||
| LUA_LIB_DIR ?= $(PREFIX)/share/lua/$(LUA_VERSION) | ||
| LUA_LIB_DIR ?= $(PREFIX)/lib/lua/$(LUA_VERSION) |
There was a problem hiding this comment.
Let's keep the original LUA_LIB_DIR and comment out the LUA_VERSION.
Instead we add an echo warning message under the install target.
lynch1981
changed the title
|
Thanks to @zhuizhuhaomeng for the detailed description of the installation chapter |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #449
I hereby granted the copyright of the changes in this pull request
to the authors of this lua-resty-core project.