Documented remaining Attributes of classes and functions #1239
Conversation
added missing documentation
added missing documentation
added missing documentation
added missing documentation
added missing documentation
added missing documentation
added missing documentation
added missing documentation
added missing documentation
added missing documentation
added missing documentation
for more information, see https://pre-commit.ci
Added warning to run_model_on_task to avoid duplicates if no authentication
for more information, see https://pre-commit.ci
| NotImplementedError | ||
| This method is not implemented yet. | ||
|
|
||
| """ | ||
| raise NotImplementedError() | ||
|
|
||
| def get(self, repeat=0, fold=0, sample=0): |
There was a problem hiding this comment.
add typing hints here and return type
There was a problem hiding this comment.
Can you provide a hint for adding typing?
| @@ -36,14 +36,24 @@ class OpenMLTask(OpenMLBase): | |||
|
|
|||
| Parameters | |||
| ---------- | |||
| task_id : Optional[int] | |||
There was a problem hiding this comment.
I think the typing below is incorrect. This should be Union[int, None] (if possible) as it is not an optional parameter for this constructor. Hence, I would change it here and below to reflect this.
|
Hey @v-parmar thank you very much for your contribution. Could you please have a look at the suggestions from @LennartPurucker so that we can potentially merge your updates? |
Co-authored-by: Lennart Purucker <lennart.purucker@uni-siegen.de>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
Again, thank you @v-parmar! |
|
@LennartPurucker, By mistake I have deleted so many files from my PR, so can I close this pull request and open a new pull request and make all these updates in it, will it work? |
|
@v-parmar, that sounds like a good idea, I will look for the new PR and comment on it. But make sure to include your most recent changes, thank you! |
|
Sure. Thank you |
Reference Issue
#716
What does this PR implement/fix? Explain your changes.
I have added the missing documentation for attributes of classes and functions.