8283339: TypeError: undefined is not an Object after JDK-8240299

[cushon]

Contributed-by: Nicholas Burbaum nburbaum@google.com

---

Progress

• Change must not contain extraneous whitespace
• Change must be properly reviewed

Issue

• JDK-8283339: TypeError: undefined is not an Object after JDK-8240299

Reviewers

• Attila Szegedi (@szegedi - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/nashorn pull/17/head:pull/17
$ git checkout pull/17

Update a local copy of the PR:
$ git checkout pull/17
$ git pull https://git.openjdk.java.net/nashorn pull/17/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 17

View PR using the GUI difftool:
$ git pr show -t 17

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/nashorn/pull/17.diff

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into main will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[szegedi]

I see that Nicholas has no OCA on file, but I'll presume that we can proceed without him signing one since:

• we can consider him a Participant instead of Contributor as per OpenJDK Bylaws as this I believe qualifies as a "small patch", and
• he would fall under OCA Google signed (visible on the OCAs submitted prior to 2021 page.)

[szegedi]

Please add a newline at the end of file. It's weird the test passes since print(a) on line 34 in the test does emit a newline.

[cushon]

Done, thanks for the review!

[openjdk]

@cushon This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8283339: TypeError: undefined is not an Object after JDK-8240299

Reviewed-by: attila

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the main branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@szegedi) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[cushon]

/integrate

[openjdk]

@cushon
Your change (at version a6dd21d) is now ready to be sponsored by a Committer.

[cushon]

I pushed one more commit to fix the newly-added file to have Google copyright (which is standard, see e.g. this thread).

[cushon]

@szegedi thanks for the review! I don't have committer status, so when you're ready for this to be merged I think you'll need to sponsor it before it can be merged by commenting /sponsor

[szegedi]

I believe you need to re-integrate after the last commit, and then I can sponsor it. You can see that the bot removed the "sponsor" label after you added the commit after integration.

[cushon]

/integrate

[openjdk]

@cushon
Your change (at version 2afb0a1) is now ready to be sponsored by a Committer.

[szegedi]

/sponsor

[openjdk]

Going to push as commit ba9bc19.

[openjdk]

@szegedi @cushon Pushed as commit ba9bc19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[szegedi]

Hey @cushon, just wanted to let you know that this is now released in Nashorn 15.4. Thanks again for the contribution!