Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8351034: Add AVX-512 intrinsics for ML-DSA #23860

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ferakocz
Copy link
Contributor

@ferakocz ferakocz commented Mar 3, 2025

By using the AVX-512 vector registers the speed of the computation of the ML-DSA algorithms (key generation, document signing, signature verification) can be approximately doubled.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8351034: Add AVX-512 intrinsics for ML-DSA (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23860/head:pull/23860
$ git checkout pull/23860

Update a local copy of the PR:
$ git checkout pull/23860
$ git pull https://git.openjdk.org/jdk.git pull/23860/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23860

View PR using the GUI difftool:
$ git pr show -t 23860

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23860.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 3, 2025

👋 Welcome back ferakocz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 3, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title JDK-8351034 Add AVX-512 intrinsics for ML-DSA 8351034: Add AVX-512 intrinsics for ML-DSA Mar 3, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 3, 2025
@openjdk
Copy link

openjdk bot commented Mar 3, 2025

@ferakocz The following labels will be automatically applied to this pull request:

  • graal
  • hotspot
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org security security-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Mar 3, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 3, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant