Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8350983: JShell LocalExecutionControl only needs stopCheck() on backward branches #23850

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

archiecobbs
Copy link
Contributor

@archiecobbs archiecobbs commented Mar 1, 2025

JShell's LocalExecutionControl ensures a running eval thread can be stopped by JShell.stop() by inserting an invocation of stopCheck() at every branch point in the bytecode of loaded classfiles.

However, this same guarantee can be provided by invoking stopCheck() only at backward branches and not at forward branches. By doing this, the performance and size impact on the executing code can be reduced.

Fortunately the new ClassFile API makes this kind of modification easy 👍


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8350983: JShell LocalExecutionControl only needs stopCheck() on backward branches (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23850/head:pull/23850
$ git checkout pull/23850

Update a local copy of the PR:
$ git checkout pull/23850
$ git pull https://git.openjdk.org/jdk.git pull/23850/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23850

View PR using the GUI difftool:
$ git pr show -t 23850

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23850.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 1, 2025

👋 Welcome back acobbs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Mar 1, 2025

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot added the rfr Pull request is ready for review label Mar 1, 2025
@openjdk
Copy link

openjdk bot commented Mar 1, 2025

@archiecobbs The following label will be automatically applied to this pull request:

  • kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the kulla kulla-dev@openjdk.org label Mar 1, 2025
@mlbridge
Copy link

mlbridge bot commented Mar 1, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kulla kulla-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

2 participants