Add a SSE reconnection mechanism #1807
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The heartbeat callback is called in the alive message listener and doesn't need to be called again inside setKeepalive method. The intervalId is removed on clearKeepalive. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
This implements a reconnection mechanism on SSE failure that attempts a reconnection after 10 seconds. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Job #896: Bundle Size — 15.67MiB (~-0.01%).Metrics (1 change)
Total size by type (2 changes)
|
Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
|
This is critical and very sensitive code but it also seems like with those changes it received proper care and should therefore be tested properly, so I cannot do that right now, but will do!
|
|
I agree that this should be tested, I am already doing that in my production since Tuesday. Works fine until now. Together with #1808 I have noticed that, if I leave Safari on my iPad and come back, the SSE connection is lost, but however thanks thanks to this PR it is restored in a matter of seconds. |
digitaldan
reviewed
Apr 1, 2023
The heartbeatCallback should be called when the SSE connection times out. Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
ghys
approved these changes
Apr 5, 2023
ghys
pushed a commit
that referenced
this pull request
Apr 6, 2023
Depends on #1807. Currently, SSE connection and sending commands fail silently, which makes the user think that everything is fine, but instead outdated values are displayed and commands are not sent. This implements user warnings for such cases, a large openHAB orange toast "Communication failure" with the option to reload is displayed at the bottom center: - as long as SSE connection is broken - when sending a command to an Item failed for 5 sec If the Item does not exist (error code 404), "<Itemname> not found" is displayed for 5 sec -- Signed-off-by: Florian Hotze <florianh_dev@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on SSE failure there is no reliable reconnection mechanism (browsers might try something), e.g. on network failure, and therefore SSE connection is lost forever once an error occurs. To reconnect, the user has to change/reload the page.
This implements a SSE reconnection mechanism, that attempts a SSE reconnection after SSE failure.
The time is increasing from 1 -> 2 -> 4 -> 8 -> 10.