Add Home Builder and Android app articles from external repos #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 16, 2017 14:14
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
Signed-off-by: Thomas Dietrich <Thomas.Dietrich@tu-ilmenau.de>
kubawolanin
approved these changes
Dec 16, 2017
|
|
||
| # Home Builder | ||
|
|
||
| Boilerplate for the [Items](http://docs.openhab.org/configuration/items.html), [sitemap](http://docs.openhab.org/configuration/sitemaps.html) files and [HABPanel](http://docs.openhab.org/addons/uis/habpanel/readme.html) dashboard. |
There was a problem hiding this comment.
Should I change it to {{base}} in the original file?
There was a problem hiding this comment.
I have checked the openhabian repo to evaluate this and there are also absolute urls in the readme.
I think it should stay as it is.
There was a problem hiding this comment.
Note that this is merely a copied version from /~https://github.com/openhab/openhab-core/blob/master/bundles/org.openhab.ui.homebuilder/USAGE.md, so there is no need to complain about it on this PR :-)
So, yes, absolute urls are imho ok (because that page also exists on github elsewhere), but all of them should actually use https and not http. I'll leave a comment on PR in openhab-core...
openhab-bot
approved these changes
Dec 16, 2017
kaikreuzer
approved these changes
Dec 16, 2017
mueller-ma
added a commit
to openhab/openhab-android
that referenced
this pull request
Dec 17, 2017
Add usage.md. See openhab/openhab-docs#594 Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kaikreuzer please check the entries in
user-menuandpackages.mdResolves #591
Related to openhab/openhab-core#263
Resolves openhab/openhab-android#495
Related to openhab/openhab-android#509
cc @kubawolanin @mueller-ma
Signed-off-by: Thomas Dietrich thomas.dietrich@tu-ilmenau.de (github: ThomDietrich)