Reduce SAT warnings #4567
Open
Reduce SAT warnings #4567
+8
−32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #4555.
Address PMD warnings.
Cleanup PMD suppressions, add local // NOPMD tags where readability is preferred over PMD rule.
After @J-N-K s comment about code restructuring to avoid SimplifyBooleanReturn, the related changes proposed in #4555 are no longer intended.
I agree that complying to this warning leads to code that is harder to read and understand. I already had ignored some of those warnings to stick with better readability when I created #4555. But maybe it is better not to go for those changes at all.
I could bring the rule set to core and do this change already now, but I think it does not make sense to duplicate the ruleset.
So I will propose to remove SimplifyBooleanReturn warning from the standard rule set in next SAT release.