Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for channel-groups to update instructions #3391

Merged
merged 4 commits into from
Mar 7, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 20, 2023

Follow-up to #3330

openhab/openhab-addons#14460 shows that we need channel-group support for the update instructions.

@J-N-K J-N-K added the enhancement An enhancement or new feature of the Core label Feb 20, 2023
@J-N-K J-N-K requested a review from a team as a code owner February 20, 2023 20:07
@mhilbush
Copy link
Contributor

Also noting that someone (@kaikreuzer?) will need to upload the revised xsd.

Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K force-pushed the update-channelgroups branch from 636e1b1 to d101dd3 Compare February 24, 2023 15:37
Signed-off-by: Jan N. Klug <github@klug.nrw>
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/openhab-4-0-snapshot-discussion/142322/221

@lolodomo
Copy link
Contributor

lolodomo commented Mar 7, 2023

@kaikreuzer : maybe something to merge (with corresponding add-ons PRs) before releasing the first milestone to get a first feedback from this new interesting feature (thing update).

Copy link
Member

@kaikreuzer kaikreuzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kaikreuzer kaikreuzer merged commit d0a0e6d into openhab:main Mar 7, 2023
@kaikreuzer kaikreuzer added this to the 4.0 milestone Mar 7, 2023
@kaikreuzer
Copy link
Member

FTR: I have published the updated xsd here: openhab/website@6ceb4f0

@J-N-K J-N-K deleted the update-channelgroups branch March 7, 2023 21:19
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* Add support for channel-groups to update instructions

Signed-off-by: Jan N. Klug <github@klug.nrw>
GitOrigin-RevId: d0a0e6d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature of the Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants