Fix AbstractScriptFileWatcher for windows

[J-N-K]

Fixes #3386

This fixes a real bug with script start-level handling on windows systems.

[J-N-K]

Is there any reason why we don't have the Windows GHA builds for this repo? I guess it's less important for openhab-addons since most file-handling is done in core, but I would appreciate it here.

[J-N-K]

GHA failed unrelated.

[wborn]

Thanks for having a look again.

It seems there is still one failing test, see: /~https://github.com/wborn/openhab-core/actions/runs/4217807817/jobs/7329491804

[ERROR] Tests run: 21, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 19.773 s <<< FAILURE! - in org.openhab.core.automation.module.script.rulesupport.loader.AbstractScriptFileWatcherTest
[ERROR] org.openhab.core.automation.module.script.rulesupport.loader.AbstractScriptFileWatcherTest.testScriptEngineRemovedOnFailedLoad  Time elapsed: 1.156 s  <<< FAILURE!
Wanted but not invoked:
scriptEngineManagerMock.createScriptEngine(
    "js",
    "C:\Users\RUNNER~1\AppData\Local\Temp\junit1841477773041771757\script.js"
);
-> at org.openhab.core.automation.module.script.rulesupport.loader.AbstractScriptFileWatcherTest.testScriptEngineRemovedOnFailedLoad(AbstractScriptFileWatcherTest.java:588)

However, there was exactly 1 interaction with this mock:
scriptEngineManagerMock.addFactoryChangeListener(
    org.openhab.core.automation.module.script.rulesupport.loader.AbstractScriptFileWatcherTest$1@7ce4de34
);
-> at org.openhab.core.automation.module.script.rulesupport.loader.AbstractScriptFileWatcher.<init>(AbstractScriptFileWatcher.java:108)

I still have adding macOS/Windows GHA builds on my todo list. The macOS build is a lot faster now that #3004 got merged.

Whenever I trigger Windows builds, they often fail due to all the unstable tests. But I guess those issues will get more attention once Windows is added to the matrix. 😉

[J-N-K]

I guess this really is an unstable test (it did not fail on my local builds). Since all the tests use 10s timeout and this one uses 1s, most probably the timeout is too short with parallel builds on low power machines.

[wborn]

It builds successfully on Windows now! 👍