Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Marketplace add-on range pattern matching #3288

Merged
merged 2 commits into from
Dec 30, 2022
Merged

Conversation

wborn
Copy link
Member

@wborn wborn commented Dec 30, 2022

With this fix it will use the correct string for pattern matching add-on version ranges introduced in #2811.

With this fix it will use the correct string for pattern matching add-on version ranges introduced in openhab#2811.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the bug An unexpected problem or unintended behavior of the Core label Dec 30, 2022
@wborn wborn requested a review from a team as a code owner December 30, 2022 16:45
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/marketplace-rules-for-3-4-0-vs-4-0-0-new-bindings/142358/9

@wborn wborn marked this pull request as draft December 30, 2022 17:26
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is there a reason this is a draft?

@wborn
Copy link
Member Author

wborn commented Dec 30, 2022

It still acts strange for snapshot versions so I'm looking into that.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn marked this pull request as ready for review December 30, 2022 18:34
@wborn
Copy link
Member Author

wborn commented Dec 30, 2022

It seems to work OK. I had forgotten 4.0.0 milestone/snapshot versions are considered compatible when using a [3.3.0;4.0.0) range. It is also a bit confusing that it takes a while before the REST API returns topic title changes. Some additional debug logging helps with explaining what is happening.

Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K J-N-K merged commit 5e23b0e into openhab:main Dec 30, 2022
@J-N-K J-N-K added this to the 4.0 milestone Dec 30, 2022
@wborn wborn deleted the fix-mp-ranges branch December 30, 2022 20:11
wborn added a commit that referenced this pull request Dec 30, 2022
* Fix Marketplace add-on range pattern matching

With this fix it will use the correct string for pattern matching add-on version ranges introduced in #2811.

Signed-off-by: Wouter Born <github@maindrain.net>
@wborn wborn added the patch A PR that has been cherry-picked to a patch release branch label Dec 30, 2022
splatch pushed a commit to ConnectorIO/copybara-hab-core that referenced this pull request Jul 12, 2023
* Fix Marketplace add-on range pattern matching

With this fix it will use the correct string for pattern matching add-on version ranges introduced in openhab#2811.

Signed-off-by: Wouter Born <github@maindrain.net>
GitOrigin-RevId: 5e23b0e
@openhab-bot
Copy link
Collaborator

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/millheat-local-api-development-questions/160139/146

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of the Core patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants