-
-
Notifications
You must be signed in to change notification settings - Fork 429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Marketplace add-on range pattern matching #3288
Conversation
With this fix it will use the correct string for pattern matching add-on version ranges introduced in openhab#2811. Signed-off-by: Wouter Born <github@maindrain.net>
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/marketplace-rules-for-3-4-0-vs-4-0-0-new-bindings/142358/9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Is there a reason this is a draft?
It still acts strange for snapshot versions so I'm looking into that. |
Signed-off-by: Wouter Born <github@maindrain.net>
It seems to work OK. I had forgotten 4.0.0 milestone/snapshot versions are considered compatible when using a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
* Fix Marketplace add-on range pattern matching With this fix it will use the correct string for pattern matching add-on version ranges introduced in #2811. Signed-off-by: Wouter Born <github@maindrain.net>
* Fix Marketplace add-on range pattern matching With this fix it will use the correct string for pattern matching add-on version ranges introduced in openhab#2811. Signed-off-by: Wouter Born <github@maindrain.net> GitOrigin-RevId: 5e23b0e
This pull request has been mentioned on openHAB Community. There might be relevant details there: https://community.openhab.org/t/millheat-local-api-development-questions/160139/146 |
With this fix it will use the correct string for pattern matching add-on version ranges introduced in #2811.