Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade plugins #18042

Merged
merged 1 commit into from
Jan 5, 2025
Merged

Upgrade plugins #18042

merged 1 commit into from
Jan 5, 2025

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Jan 5, 2025 •
edited
Loading

  • maven-site-plugin to 3.21.0
  • maven-plugin-plugin to 3.15.1

I missed those two in #18037.

Now all plugins are up to date (besides openapi-generator, which is blocked by an issue, see openhab/openhab-webui#2975 (comment))

Beta versions are ignored, mvn command line:
mvn versions:display-plugin-updates -nsu -Dmaven.version.ignore=".*-beta-.*,.*\.BETA[0-9]+,.*-M[0-9]+" -B -Dversions.outputLineWidth=120

@holgerfriedrich
Upgrade plugins
d211e54 
* maven-site-plugin to 3.21.0
* maven-plugin-plugin to 3.15.1

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@holgerfriedrich holgerfriedrich requested a review from a team as a code owner January 5, 2025 11:51
jlaur
jlaur approved these changes Jan 5, 2025
View reviewed changes
Copy link
Contributor

@jlaur jlaur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jlaur jlaur added the infrastructure Build system and Karaf related issues and PRs label Jan 5, 2025
@jlaur jlaur merged commit bbec3d5 into openhab:main Jan 5, 2025
2 checks passed
@jlaur jlaur added this to the 5.0 milestone Jan 5, 2025
@holgerfriedrich holgerfriedrich deleted the pr-plugins branch January 5, 2025 13:20
@kaikreuzer
Copy link
Member

The sandbox builds are failing and from the code changes that I can see, this PR might potentially be the culprit.
I am not sure how those two plugins could cause this, but I am open for ideas. 😄

@holgerfriedrich
Copy link
Member Author

holgerfriedrich commented Jan 7, 2025 •
edited
Loading

@kaikreuzer likely.... these kind of upgrades tend to have side effects.....

Which version of maven do we use in the Jenkins builds? Could you try to upgrade this to latest 3.x version? This may help with the builds sometimes broken with the "wrong encodung \u..." failure.

A workaround could be to increase the lock timeout. I have read that -Daether.syncContext.named.time=60 may help (default is 30sec).

@kaikreuzer
Copy link
Member

We are always using the latest Maven version, currently 3.9.9.
Today, the build actually succeeds. So maybe let us watch how it behaves for a while to see how big the issue really is.

@holgerfriedrich holgerfriedrich mentioned this pull request Jan 11, 2025
Open
4 tasks
GearrelW pushed a commit to GearrelW/openhab-addons that referenced this pull request Jan 12, 2025
@holgerfriedrich @GearrelW
Upgrade plugins (openhab#18042)
6aeeee0 
* maven-site-plugin to 3.21.0
* maven-plugin-plugin to 3.15.1

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlaur jlaur jlaur approved these changes

Assignees
No one assigned
Labels
infrastructure Build system and Karaf related issues and PRs
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.
3 participants
@holgerfriedrich @kaikreuzer @jlaur