Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[googletts] Fix authentication after communication error #15747

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented Oct 13, 2023

Fixes openhab#15746

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added bug An unexpected problem or unintended behavior of an add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Oct 13, 2023
@jlaur jlaur requested a review from gbicskei as a code owner October 13, 2023 09:06
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you

@lolodomo
Copy link
Contributor

@Artur-Fedjukevits : can you test this fix before I merge it ?
@jlaur you could link the jar for testing ?

@jlaur
Copy link
Contributor Author

jlaur commented Oct 14, 2023

@jlaur you could link the jar for testing ?

Good idea, done. When tested, I would suggest to also cherry-pick this into 4.0.x.

@lolodomo
Copy link
Contributor

@jlaur you could link the jar for testing ?

Good idea, done.

Ah, this was already done in the issue.

@Artur-Fedjukevits
Copy link
Contributor

@Artur-Fedjukevits : can you test this fix before I merge it ? @jlaur you could link the jar for testing ?

Sorry for the delay. Tonight I will check it.

@Artur-Fedjukevits
Copy link
Contributor

Tested! Everything is working.

@jlaur jlaur removed the additional testing preferred The change works for the pull request author. A test from someone else is preferred though. label Oct 16, 2023
@lolodomo lolodomo merged commit eadfd58 into openhab:main Oct 16, 2023
@lolodomo lolodomo added this to the 4.1 milestone Oct 16, 2023
@jlaur
Copy link
Contributor Author

jlaur commented Oct 16, 2023

When tested, I would suggest to also cherry-pick this into 4.0.x.

@lolodomo - thanks for the review. Do you agree to backport the fix?

@lolodomo
Copy link
Contributor

Ok

@jlaur jlaur deleted the 15746-googletts-oauth2-reset branch October 16, 2023 19:22
jlaur added a commit that referenced this pull request Oct 16, 2023
Fixes #15746

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur added the patch A PR that has been cherry-picked to a patch release branch label Oct 16, 2023
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 21, 2023
Fixes openhab#15746

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
querdenker2k pushed a commit to querdenker2k/openhab-addons that referenced this pull request Oct 29, 2023
Fixes openhab#15746

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: querdenker2k <querdenker2k@gmx.de>
austvik pushed a commit to austvik/openhab-addons that referenced this pull request Mar 27, 2024
Fixes openhab#15746

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Signed-off-by: Jørgen Austvik <jaustvik@acm.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An unexpected problem or unintended behavior of an add-on patch A PR that has been cherry-picked to a patch release branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[googletts] Missing service configuration
3 participants