Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[jsscripting] Fix JSScriptFileWatcher not ignoring correct directory #14393

Merged
merged 2 commits into from
Feb 15, 2023
Merged

[jsscripting] Fix JSScriptFileWatcher not ignoring correct directory #14393

merged 2 commits into from
Feb 15, 2023

Conversation

J-N-K
Copy link
Member

@J-N-K J-N-K commented Feb 14, 2023

Depends on openhab/openhab-core#3369

Signed-off-by: Jan N. Klug github@klug.nrw

@J-N-K
[jsscripting] Fix JSScriptFileWatcher not ignoring correct directory
d7a9b8b 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@J-N-K J-N-K added bug An unexpected problem or unintended behavior of an add-on awaiting other PR Depends on another PR regression Regression that happened during the development of a release. Not shown on final release notes. labels Feb 14, 2023
@J-N-K J-N-K requested a review from florian-h05 as a code owner February 14, 2023 10:04
@J-N-K
improvement
46c87ca 
Signed-off-by: Jan N. Klug <github@klug.nrw>
@florian-h05 florian-h05 added rebuild Triggers Jenkins PR build and removed awaiting other PR Depends on another PR rebuild Triggers Jenkins PR build labels Feb 14, 2023
wborn
wborn approved these changes Feb 15, 2023
View reviewed changes
Copy link
Member

@wborn wborn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@wborn wborn merged commit 9a05e9f into openhab:main Feb 15, 2023
@wborn wborn added this to the 4.0 milestone Feb 15, 2023
@J-N-K J-N-K deleted the bug-fixjsfilewatcher branch February 15, 2023 09:43
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Feb 28, 2023
@J-N-K @nemerdaud
[jsscripting] Fix JSScriptFileWatcher not ignoring correct directory (o…
591f8d2 
…penhab#14393)

Signed-off-by: Jan N. Klug <github@klug.nrw>
renescherer pushed a commit to renescherer/openhab-addons that referenced this pull request Mar 23, 2023
@J-N-K @renescherer
[jsscripting] Fix JSScriptFileWatcher not ignoring correct directory (o…
6a6cce2 
…penhab#14393)

Signed-off-by: Jan N. Klug <github@klug.nrw>
FordPrfkt pushed a commit to FordPrfkt/openhab-addons that referenced this pull request Apr 20, 2023
@J-N-K @FordPrfkt
[jsscripting] Fix JSScriptFileWatcher not ignoring correct directory (o…
308b9c2 
…penhab#14393)

Signed-off-by: Jan N. Klug <github@klug.nrw>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wborn wborn wborn approved these changes

@florian-h05 florian-h05 Awaiting requested review from florian-h05 florian-h05 is a code owner

Assignees
No one assigned
Labels
bug An unexpected problem or unintended behavior of an add-on regression Regression that happened during the development of a release. Not shown on final release notes.
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@J-N-K @wborn @florian-h05