Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[miio] Initial i18n properties file for Xiaomi miio binding #11563

Merged
merged 2 commits into from
Nov 11, 2021

Conversation

marcelrv
Copy link
Contributor

Signed-off-by: Marcel Verpaalen marcel@verpaalen.com

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@marcelrv marcelrv added the i18n label Nov 11, 2021
@marcelrv marcelrv requested a review from wborn November 11, 2021 15:15
@lolodomo
Copy link
Contributor

@marcelrv : ideally you should use @text rather than a hardcoded English text when calling updateStatus in your thing handler.

@lolodomo lolodomo added translation and removed i18n labels Nov 11, 2021
@marcelrv
Copy link
Contributor Author

@lolodomo I see this indeed as a very first step in making the binding i18n compatible.
e.g. the 1250+ dynamically created channels defined infor the things also need a solution. (I did not yet see easy solution for those...)

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@lolodomo
Copy link
Contributor

It looks like all channel types are not there in the properties file. An example: MijiaVacuumV2_fan-level

@marcelrv
Copy link
Contributor Author

It looks like all channel types are not there in the properties file. An example: MijiaVacuumV2_fan-level

Yes, because they are about to be removed #11568

Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, hoping there are no forgotten channel types.

@lolodomo lolodomo merged commit 40d8e1c into openhab:main Nov 11, 2021
@lolodomo lolodomo added this to the 3.2 milestone Nov 11, 2021
@marcelrv marcelrv deleted the miio-i18 branch November 12, 2021 08:41
NickWaterton pushed a commit to NickWaterton/openhab-addons that referenced this pull request Dec 30, 2021
…11563)

* [miio] Initial i18n properties file

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] add status msg to i18n

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Nick Waterton <n.waterton@outlook.com>
mischmidt83 pushed a commit to mischmidt83/openhab-addons that referenced this pull request Jan 9, 2022
…11563)

* [miio] Initial i18n properties file

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] add status msg to i18n

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
nemerdaud pushed a commit to nemerdaud/openhab-addons that referenced this pull request Jan 28, 2022
…11563)

* [miio] Initial i18n properties file

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] add status msg to i18n

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
marcfischerboschio pushed a commit to bosch-io/openhab-addons that referenced this pull request May 5, 2022
…11563)

* [miio] Initial i18n properties file

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] add status msg to i18n

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
andan67 pushed a commit to andan67/openhab-addons that referenced this pull request Nov 6, 2022
…11563)

* [miio] Initial i18n properties file

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>

* [miio] add status msg to i18n

Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants