-
-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[miio] Initial i18n properties file for Xiaomi miio binding #11563
Conversation
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
@lolodomo I see this indeed as a very first step in making the binding i18n compatible. |
Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
It looks like all channel types are not there in the properties file. An example: MijiaVacuumV2_fan-level |
Yes, because they are about to be removed #11568 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, hoping there are no forgotten channel types.
…11563) * [miio] Initial i18n properties file Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add status msg to i18n Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Nick Waterton <n.waterton@outlook.com>
…11563) * [miio] Initial i18n properties file Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add status msg to i18n Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> Signed-off-by: Michael Schmidt <mi.schmidt.83@gmail.com>
…11563) * [miio] Initial i18n properties file Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add status msg to i18n Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
…11563) * [miio] Initial i18n properties file Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add status msg to i18n Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
…11563) * [miio] Initial i18n properties file Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com> * [miio] add status msg to i18n Signed-off-by: Marcel Verpaalen <marcel@verpaalen.com>
Signed-off-by: Marcel Verpaalen marcel@verpaalen.com