feat: cond routingv1.1 #8031
Open
feat: cond routingv1.1 #8031
+57
−50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 1746 Passed, 0 Skipped, 3m 54.92s Total duration (2m 59.78s time saved) |
kevin9foong
force-pushed
the
feat/cond-routingv1.1
branch
from
bdb6c8f to
676b4f4
Compare
kevin9foong
force-pushed
the
feat/cond-routingv1.1
branch
from
676b4f4 to
d6fa6a3
Compare
|
need to re-eval / test if using |
I've verified with Kenneth yesterday and tested. works as expected. No issues. PR ready for review! |
KenLSM
reviewed
Jan 13, 2025
There was a problem hiding this comment.
This file is quite huge, standing at 9MB. Did a brief check on our gifs in the repo, they aren't so huge (~300kb).
@alicia-ogp you have a smaller version of the gif? What something along the lines of 1000width instead of 1600width
KenLSM
requested changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
General changes to improve experience for conditional routing before GA.
Closes FRM-1927
Solution
Breaking Changes
No - this PR is backwards compatible
Tests