fix: fix mypy and flake8 issues

after mypy and flake8 upgrade

robotoff/app/api.py

@@ -1075,12 +1075,9 @@ def on_get(self, req: falcon.Request, resp: falcon.Response):
 
 class DumpResource:
     def on_get(self, req: falcon.Request, resp: falcon.Response):
-        keep_types: Optional[List[str]] = req.get_param_as_list(
-            "insight_types", required=False
-        )
-
-        if keep_types is not None:
-            keep_types = keep_types[:10]
+        keep_types: List[str] = req.get_param_as_list(
+            "insight_types", required=False, default=[]
+        )[:10]
 
         barcode = req.get_param("barcode")
         annotated = req.get_param_as_bool("annotated", blank_as_true=False)

robotoff/app/core.py

@@ -64,9 +64,9 @@ def _add_vote_exclusions(
 
 def get_insights(
     barcode: Optional[str] = None,
-    keep_types: List[str] = None,
-    country: str = None,
-    brands: List[str] = None,
+    keep_types: Optional[List[str]] = None,
+    country: Optional[str] = None,
+    brands: Optional[List[str]] = None,
     annotated: Optional[bool] = False,
     annotation: Optional[int] = None,
     order_by: Optional[str] = None,
@@ -199,7 +199,7 @@ def get_images(
 
 def get_predictions(
     barcode: Optional[str] = None,
-    keep_types: List[str] = None,
+    keep_types: Optional[List[str]] = None,
     value_tag: Optional[str] = None,
     server_domain: Optional[str] = None,
     limit: Optional[int] = 25,
@@ -393,7 +393,7 @@ def save_annotation(
 
 def get_logo_annotation(
     barcode: Optional[str] = None,
-    keep_types: List[str] = None,
+    keep_types: Optional[List[str]] = None,
     value_tag: Optional[str] = None,
     server_domain: Optional[str] = None,
     limit: Optional[int] = 25,

robotoff/app/events.py

@@ -1,4 +1,5 @@
 from multiprocessing import Process, SimpleQueue
+from typing import Optional
 
 import requests
 
@@ -48,7 +49,7 @@ def send_event(
     event_type: str,
     user_id: str,
     device_id: str,
-    barcode: str = None,
+    barcode: Optional[str] = None,
 ):
     event = {
         "event_type": event_type,

robotoff/insights/importer.py

@@ -566,7 +566,9 @@ def update_fields(
                 setattr(reference_insight, field_name, getattr(insight, field_name))
 
     @classmethod
-    def add_optional_fields(cls, insight: ProductInsight, product: Product):
+    def add_optional_fields(  # noqa: B027
+        cls, insight: ProductInsight, product: Product
+    ):
         """Overwrite this method in children classes to add optional fields.
 
         The `campaign` field should be populated here.
@@ -1033,7 +1035,7 @@ def import_product_predictions(
     return batch_insert(PredictionModel, to_import, 50)
 
 
-IMPORTERS: List[Type[InsightImporter]] = [
+IMPORTERS: List[Type] = [
     PackagerCodeInsightImporter,
     LabelInsightImporter,
     CategoryImporter,

robotoff/off.py

@@ -198,7 +198,7 @@ def is_valid_image(barcode: str, image_id: str) -> bool:
 
 def get_product(
     barcode: str,
-    fields: List[str] = None,
+    fields: Optional[List[str]] = None,
     server: Optional[Union[ServerType, str]] = None,
     timeout: Optional[int] = 10,
 ) -> Optional[Dict]:
@@ -358,7 +358,7 @@ def save_ingredients(
     barcode: str,
     ingredient_text: str,
     insight_id: Optional[str] = None,
-    lang: str = None,
+    lang: Optional[str] = None,
     comment: Optional[str] = None,
     **kwargs,
 ):

robotoff/prediction/object_detection/core.py

@@ -154,7 +154,7 @@ def detect_from_image(
                 dtype=np.float32,
             )
             .reshape((1, 1))
-            .astype(np.int)[0][0]
+            .astype(np.int)[0][0]  # type: ignore
         )
         detection_scores = np.frombuffer(
             response.raw_output_contents[output_index["detection_scores"]],
@@ -166,7 +166,7 @@ def detect_from_image(
                 dtype=np.float32,
             )
             .reshape((1, -1))
-            .astype(np.int)
+            .astype(np.int)  # type: ignore
         )[0]
         detection_boxes = np.frombuffer(
             response.raw_output_contents[output_index["detection_boxes"]],

robotoff/prediction/ocr/core.py

@@ -129,7 +129,7 @@ def is_barcode(text: str):
 
 
 def get_source(
-    image_name: str, json_path: str = None, barcode: Optional[str] = None
+    image_name: str, json_path: Optional[str] = None, barcode: Optional[str] = None
 ) -> str:
     if not barcode:
         barcode = get_barcode_from_path(str(json_path))

robotoff/utils/cache.py

@@ -1,4 +1,3 @@
-import abc
 import datetime
 from typing import Callable, Optional
 
@@ -7,7 +6,7 @@
 logger = get_logger(__name__)
 
 
-class CachedStore(metaclass=abc.ABCMeta):
+class CachedStore:
     def __init__(self, fetch_func: Callable, expiration_interval: Optional[int] = 30):
         self.store = None
         self.expires_after: Optional[datetime.datetime] = None

robotoff/workers/client.py

@@ -1,13 +1,13 @@
 from multiprocessing.connection import Client
-from typing import Dict
+from typing import Dict, Optional
 
 from robotoff import settings
 from robotoff.utils import get_logger
 
 logger = get_logger(__name__)
 
 
-def send_ipc_event(event_type: str, meta: Dict = None):
+def send_ipc_event(event_type: str, meta: Optional[Dict] = None):
     meta = meta or {}
 
     logger.info("Connecting listener server on {}:{}" "".format(*settings.IPC_ADDRESS))