-
-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added Layout and basic code to native sign-up #3737
base: develop
Are you sure you want to change the base?
Conversation
We should probably have some consent for the TOS and the Open Food Facts newsletter, and possibly support for teams ? |
Should I add 3 chekbox (each for TOS, newsletter and Professional Account) and one Edittext for Team (optional) ? |
@mrudultora let's see how it looks like |
|
@teolemon How's this ? |
@stephanegigandet ? @VaiTon ? What do you think ? |
@teolemon In which direction shall I proceed now ? |
@teolemon Is there any minimum length fixed for username ? |
@teolemon I have made the changes and added a regex check for username. Also mentioned in the layout about the conditions for username. And changed the strings accordingly. |
@stephanegigandet should we ask for the organisation name if the producer box is ticked |
@teolemon Any Updates ? |
Let's add it, since it's in the web form https://world.pro.openfoodfacts.org/cgi/user.pl |
@teolemon Added. Producer or Brand name textInputEditText will be visible when food producer checkbox is ticked and hides when that checkbox is unticked. |
9527cdc
to
10adf03
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
HTTP POST
Professional account
Additional fields:
|
Are these mandatory for every account or only for producer accounts? |
@VaiTon I believe that kind of thing is for all accounts. It's something @stephanegigandet adds frequently to his forms |
@mrudultora fixed the merge conflicts and rebased |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@mrudultora @VaiTon fixed the merge conflicts and rebased |
rebased @mrudultora @VaiTon Can we go the simple route, and use the current url to send the form ? |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
i've rebased on latest develop, but this PR currently doesn't use databinding. As a result:
|
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Description
• Created SignupActivity
• Added basic code to SignupActivity.kt and completed layout of SignupActivity
• Added related strings in
strings.xml
Related issues
Related PRs
Screenshots