feat: reporting images added #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nobeeakon
reviewed
Aug 14, 2022
nobeeakon
reviewed
Aug 14, 2022
nobeeakon
reviewed
Aug 14, 2022
nobeeakon
reviewed
Aug 14, 2022
nobeeakon
reviewed
Aug 14, 2022
nobeeakon
reviewed
Aug 14, 2022
There was a problem hiding this comment.
really good @sumana2001 ... maybe it would be nice to have a tooltip in the button or a question mark icon with a tooltip next to the flag or something that explains what the flag means
nobeeakon
reviewed
Aug 14, 2022
nobeeakon
reviewed
Aug 15, 2022
nobeeakon
reviewed
Aug 15, 2022
|
I have made the changes you suggested, please have a look again. @nobeeakon @alexfauquette |
nobeeakon
reviewed
Aug 17, 2022
nobeeakon
reviewed
Aug 17, 2022
nobeeakon
reviewed
Aug 17, 2022
nobeeakon
reviewed
Aug 19, 2022
| } | ||
| ) | ||
| .catch(() => { | ||
| console.log("Something went wrong. Image could not be flagged"); |
There was a problem hiding this comment.
nit: no need for the console.log as it is not useful for the client, you could leave .catch(() => {}) and it will be fine
nobeeakon
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2022-08-14.at.2.47.40.PM.mov
Closes #22