Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scorecard-check GitHub Action #28

Merged
merged 1 commit into from
Nov 15, 2023

Conversation

ChristianZaccaria
Copy link

@ChristianZaccaria ChristianZaccaria commented Nov 10, 2023

Resolves #27

Description

Scorecard-CI is specific to OLM. Since we're not using OLM as our install methodology, this check can be removed.

This was already removed in a PR from PCF/CFO

Copy link

openshift-ci bot commented Nov 10, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign maxusmusti for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sutaakar
Copy link

Unfortunately the check is still failing

@ChristianZaccaria ChristianZaccaria changed the title Add operator-name flag to generate bundle command to fix scorecard-check Remove scorecard-check GitHub Action Nov 13, 2023
Copy link

openshift-ci bot commented Nov 13, 2023

@ChristianZaccaria: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-odh-cfo 48fa4d0 link true /test e2e-odh-cfo

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link

@Fiona-Waters Fiona-Waters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch realising this needed to be removed! Looks good to me, apart from failing e2e, which I don't think is related to this PR. Hopefully re-running will help.

@sutaakar
Copy link

PR check is currently broken, to be addressed in another PR.
This PR looks good, merging.

@sutaakar sutaakar merged commit 10d0abc into opendatahub-io:main Nov 15, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove scorecard-check GitHub Action
3 participants