[Runtime] Allow for excluding pid from state #894
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Re-base of #459; does not impact functionality but may be helpful for certification Signed-off-by: Rob Dolin <robdolin@microsoft.com>
wking
reviewed
Jul 12, 2017
There was a problem hiding this comment.
We should probably also add a pointer to the Go property and remove pid from the required section of the JSON Schema regardless of how this PR works out. I can submit a separate PR for those if we don't want to handle them here.
| @@ -23,6 +23,7 @@ The state of a container includes the following properties: | |||
|
|
|||
| Additional values MAY be defined by the runtime, however, they MUST be used to represent new runtime states not defined above. | |||
| * **`pid`** (int, REQUIRED when `status` is `created` or `running`) is the ID of the container process, as seen by the host. | |||
| The pid MAY be excluded or set to a value indicating empty or null if it is not seen by the host. | |||
There was a problem hiding this comment.
As you have it, this conflicts with the REQUIRED in the line above. Maybe pull this entry down below this list and guard it (like we do here).
For systems where the container process ID is visible from the [runtime namespace](glossary.md#runtime-namespace), the state object supports the following additional properties:
* **`pid`** (int, REQUIRED when `status` is `created` or `running`) is the ID of the container process, as seen by the host.
That also gives us an opportunity to address #731 if we want to.
|
We are going to take #895 |
|
With the PR closed, someone with write access should probably delete the local |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-base of #459; does not impact functionality but may be helpful for certification
Signed-off-by: Rob Dolin robdolin@microsoft.com