Payments Methods: Redesign settings dashboard #10726
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kewitz
force-pushed
the
refact/payment-info
branch
from
a19c96a to
3c159fc
Compare
kewitz
force-pushed
the
refact/payment-info
branch
from
aa67c54 to
f44b9ea
Compare
hdiniz
reviewed
Feb 27, 2025
server/models/PayoutMethod.ts
Outdated
| const expenses = await (sequelize.models.Expense as typeof Expense).findOne({ | ||
| where: { | ||
| PayoutMethodId: this.id, | ||
| status: { [Op.notIn]: [ExpenseStatuses.PENDING, ExpenseStatuses.DRAFT] }, |
There was a problem hiding this comment.
Do you think it would make sense to include REJECT or CANCELED as well?
There was a problem hiding this comment.
I think the question here was related to what status I know for sure we don't care about editing. With the existing expense flow, I wonder if something would end up in canceled before being edited to the correct state. But perhaps if the user submits to the wrong collective and needs to re-submit to another collective and change something in the Payout Method details, that would make sense.
hdiniz
approved these changes
Feb 27, 2025
…PaymentMethod references
kewitz
force-pushed
the
refact/payment-info
branch
from
9b5e12a to
70cefcc
Compare
|
Rebased. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves opencollective/opencollective#7837