Make invoice file separate field #10702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdiniz
force-pushed
the
make-invoice-file-separate-field
branch
from
c8eac2a to
db35082
Compare
hdiniz
force-pushed
the
make-invoice-file-separate-field
branch
2 times, most recently
from
e50883a to
ca22e29
Compare
gustavlrsn
reviewed
Feb 24, 2025
This only works without mocked uploads, we should be deprecating that asap. I added a few changes here to use minio on e2e tests for that reason. I will try to remove it entirely. |
hdiniz
force-pushed
the
make-invoice-file-separate-field
branch
from
ca22e29 to
bf5fa88
Compare
Betree
reviewed
Feb 25, 2025
| @@ -58,6 +66,14 @@ jobs: | |||
| - 5432:5432 | |||
| # needed because the postgres container does not provide a healthcheck | |||
| options: --health-cmd pg_isready --health-interval 10s --health-timeout 5s --health-retries 5 | |||
| minio: | |||
| image: minio/minio:edge-cicd | |||
There was a problem hiding this comment.
I initially wanted to use this image as well in #10688, but it hasn't been updated in 3 years and that was causing some issues in my tests (I don't remember where), which is why I went with the npm run minio & approach.
No blocker for me if the image is working here, we can always update later if needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: opencollective/opencollective#7726
Add invoice expense attachments as its own field on the expense object, differentiating from other attachment types.