-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k8s.{pod,node}.cpu.{time,usage} metrics #1320
Conversation
4354d0e
to
2dc78ea
Compare
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
2dc78ea
to
f768c35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These metrics have been in place for 4+ years (except usage, whose rename from utilization is in progress).
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@open-telemetry/specs-semconv-approvers could you also take a look? |
We probably discussed it somewhere, but could you remind me if we have cpu count available for pods/nods and if there are any plans to report it? |
The The containers define the cpu_limits/cpu_requests, so the the limits/requests of a Pod can be calculated by summarizing its containers' limits/requests. |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@lmolkova does this repo have merge queue enabled? |
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
nope, it's all manual. I enabled auto-merge for this one, but all open discussions need to be resolved to allow it to happen. |
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Changes
This PR adds the
k8s.pod.cpu.time
,k8s.pod.cpu.usage
,k8s.node.cpu.time
,k8s.node.cpu.usage
metrics.The respective Collector's implementation can be found at /~https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/main/receiver/kubeletstatsreceiver/metadata.yaml#L84
Part of #1032.
Merge requirement checklist
[chore]