Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[chore] Spelling it isn't... ...pratyush #6019

Merged
merged 8 commits into from
Jan 23, 2025
Merged

[chore] Spelling it isn't... ...pratyush #6019

merged 8 commits into from
Jan 23, 2025
+27 −27

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Jan 22, 2025

@jsoref jsoref requested a review from a team as a code owner January 22, 2025 02:48
@opentelemetrybot opentelemetrybot requested review from a team and djaglowski and removed request for a team January 22, 2025 02:48
@jsoref jsoref changed the title [chore] Spelling 4 [chore] Spelling it isn't... ...pratyush Jan 22, 2025
chalin
chalin approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

content/en/docs/kubernetes/collector/components.md Outdated Show resolved Hide resolved
@opentelemetrybot opentelemetrybot requested review from a team January 23, 2025 03:12
jsoref and others added 8 commits January 22, 2025 22:13
@jsoref @chalin
spelling: it isn't required to inject a service-level tracer and it d…
11cb280 
…oesn't improve performance.

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @chalin
spelling: its
c944207 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @chalin
spelling: javascript
a32514b 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @chalin
spelling: macos
5647331 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @chalin
spelling: modules
7047c31 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @chalin
spelling: out
0ac8987 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@jsoref @chalin
spelling: pratyush
e0976a6 
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@chalin
Fix OS order
a66a47b
@chalin chalin merged commit 14daaf1 into open-telemetry:main Jan 23, 2025
17 checks passed
@jsoref jsoref deleted the spelling-4 branch January 23, 2025 03:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reyang reyang reyang approved these changes

@chalin chalin chalin approved these changes

@djaglowski djaglowski Awaiting requested review from djaglowski djaglowski was automatically assigned from open-telemetry/collector-approvers

Assignees
No one assigned
Labels
blog sig:collector sig:dotnet
Projects
SIG Comms: PRs & Issues
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jsoref @chalin @reyang