Make collector mermaid diagrams darkmode compatible #6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opentelemetrybot
requested review from
a team and
jpkrohling
and removed request for
a team
chalin
commented
Jan 21, 2025
Comment on lines
-60
to
-61
| %% The stroke color matches the website header. | ||
| classDef default fill:#e3e8fc,stroke:#4f62ad |
There was a problem hiding this comment.
/cc @tiffany76, since you chose these original color overrides if I'm not mistaken.
There was a problem hiding this comment.
I did - tried to match the branded colors. But I totally understand that dark mode is more important, so this change is good with me.
There was a problem hiding this comment.
FYI, we're still quite close to brand colors for most of the diagrams. (I might have a solution to get rid of the yellow, but it'll take more work.)
tiffany76
approved these changes
Jan 21, 2025
|
Given that these are CSS and editorial changes, I'll merge now. Thanks for the review and approval @tiffany76 🙌🏻 |
chalin
deleted the
chalin-im-dark-mode-for-collector-mermaid-diagrams-2025-01-21
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previews
Screenshots of darkmode fixes
The only caveat is that in light mode, the last two diagrams have a yellow background (all other diagrams are the same in light mode before and after), something like this:
Fixing this has proven tricky, and would require a change to Docsy, so that the non-dark theme chosen is
baserather thandefault. But even then I couldn't get all of the colors for all of the diagrams to work. I'm submitting this PR because it is a good step forward, despite the yellow background.Related: