Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

X, previously known as Twitter in the footer and on blogs #3649

Merged
merged 9 commits into from
Dec 19, 2023

Conversation

nmummau
Copy link
Contributor

@nmummau nmummau commented Dec 5, 2023

Originally this PR was to handle issue #3647, but then I realized submodules needed updated to get the new logo (@fortawesome/fontawesome-free had to be updated in google/docsy and then the cncf/docsys fork had to be updated)

Instead of this PR handling any of those dependencies, this change was put on hold until those updates took place (which they now have).

See #3665 which broke up the "Twitter-to-X updates" and this handles one part of that issue.

  • This PR simply changes the Twitter logo in the footer to the X logo.
  • It also updates one blog post which happened after the X name change, which was the preference from @svrnm in discussions below.

@nmummau nmummau requested review from a team December 5, 2023 03:20
Copy link

linux-foundation-easycla bot commented Dec 5, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

hugo.yaml Show resolved Hide resolved
hugo.yaml Outdated Show resolved Hide resolved
content/en/blog/2022/announcing-community-manager.md Outdated Show resolved Hide resolved
content/en/blog/2022/otel-tuesday-v1-sunset.md Outdated Show resolved Hide resolved
content/en/blog/2023/end-user-discussions-02.md Outdated Show resolved Hide resolved
hugo.yaml Outdated Show resolved Hide resolved
@svrnm
Copy link
Member

svrnm commented Dec 5, 2023

@nmummau thanks for raising this PR and I appreciate the effort, but note that blog posts are historical and should be kept as they are as far as possible. Also twitter was renamed to X July 23th, so all blog posts before that should remain untouched by this change for that reason as well. I am OK with updating blog posts post re-name, but not before.

Having the logo changed on the website with the fontawesome updated is a change we can apply.

@nmummau
Copy link
Contributor Author

nmummau commented Dec 5, 2023

@svrnm I applied your suggested changes. In my mind updating the hyperlinks on old blog posts doesn't change the content of the blog post itself, which was my thought process on my initial update.

Something to consider is that the links on the old blog posts may break if Elon ever decides to stop resolving Twitter.com.

@svrnm
Copy link
Member

svrnm commented Dec 5, 2023

@svrnm I applied your suggested changes.

Thank you!

Something to consider is that the links on the old blog posts may break if Elon ever decides to stop resolving Twitter.com.

Most links to twitter link to profiles of individuals or hashtags, so I wouldn't be worried to much about them, since they might be not-active anymore already. The only tweet referenced is the one by Yuri around jaeger sunsetting their clients in favor of OpenTelemetry, which ultimately links to a github issue (which we should have linked to begin with, but same here, let's keep it that way)

@austinlparker
Copy link
Member

austinlparker commented Dec 6, 2023 via email

chalin
chalin previously requested changes Dec 6, 2023
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your proactiveness, but as you've noticed already, this PR doesn't update the logo. We need Docsy to be updated first.

Thanks also for your PR on the Docsy side, but I've closed it because it was incomplete. The good news is that there's already a complete PR in the review queue.

I take @austinlparker's joke at least half seriously, and suggest that we separate issues between logo and domain updates. For details, see #3647 (comment).

I'll be OOO so I'll let @open-telemetry/docs-maintainers decide what to do while we're waiting for the Docsy update (at least mark the PR as draft). IMHO, this isn't urgent.

@nmummau nmummau marked this pull request as draft December 6, 2023 01:05
@chalin
Copy link
Contributor

chalin commented Dec 8, 2023

Here's the update of Docsy (and FA):

Once it lands, rebase and feel free to clean up this PR to include only the changes that we've agreed to and that @svrnm mentioned. Thanks!

@chalin chalin mentioned this pull request Dec 11, 2023
5 tasks
.htmltest.yml Outdated Show resolved Hide resolved
@svrnm
Copy link
Member

svrnm commented Dec 15, 2023

#3666 is merged.

@nmummau please double check if all things are working now and then I am happy to merge.

@svrnm svrnm requested review from chalin, theletterf and svrnm December 15, 2023 10:23
@nmummau nmummau changed the title All mentions of Twitter now mention X X, previously known as Twitter in the footer and on blogs Dec 19, 2023
@nmummau nmummau marked this pull request as ready for review December 19, 2023 01:11
@nmummau
Copy link
Contributor Author

nmummau commented Dec 19, 2023

@svrnm All set!

@svrnm
Copy link
Member

svrnm commented Dec 19, 2023

/fix:format

Copy link
Contributor

You triggered fix:format action run at /~https://github.com/open-telemetry/opentelemetry.io/actions/runs/7259608975

@svrnm svrnm dismissed stale reviews from chalin and theletterf December 19, 2023 09:08

addressed

@svrnm svrnm merged commit 6491d36 into open-telemetry:main Dec 19, 2023
14 checks passed
@svrnm
Copy link
Member

svrnm commented Dec 19, 2023

🎉 thank you @nmummau

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants