-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
X, previously known as Twitter in the footer and on blogs #3649
Conversation
@nmummau thanks for raising this PR and I appreciate the effort, but note that blog posts are historical and should be kept as they are as far as possible. Also twitter was renamed to X July 23th, so all blog posts before that should remain untouched by this change for that reason as well. I am OK with updating blog posts post re-name, but not before. Having the logo changed on the website with the fontawesome updated is a change we can apply. |
@svrnm I applied your suggested changes. In my mind updating the hyperlinks on old blog posts doesn't change the content of the blog post itself, which was my thought process on my initial update. Something to consider is that the links on the old blog posts may break if Elon ever decides to stop resolving Twitter.com. |
Thank you!
Most links to twitter link to profiles of individuals or hashtags, so I wouldn't be worried to much about them, since they might be not-active anymore already. The only tweet referenced is the one by Yuri around jaeger sunsetting their clients in favor of OpenTelemetry, which ultimately links to a github issue (which we should have linked to begin with, but same here, let's keep it that way) |
we could also wait another year for when the site gets rebranded to twitter, who knows. 😛
…On Dec 5, 2023 at 7:51 PM -0500, Patrice Chalin ***@***.***>, wrote:
@chalin commented on this pull request.
In hugo.yaml:
> @@ -57,7 +57,7 @@ params:
collector services to capture distributed traces and metrics from your
application. You can analyze them using Prometheus, Jaeger, and other
observability tools.
- font_awesome_version: 5.8.1
+ font_awesome_version: 6.5.1
Ohhh, that line shouldn't be there anymore! I'm glad that this PR allowed us to pinpoint that. See:
• #3653
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because your review was requested.Message ID: ***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your proactiveness, but as you've noticed already, this PR doesn't update the logo. We need Docsy to be updated first.
Thanks also for your PR on the Docsy side, but I've closed it because it was incomplete. The good news is that there's already a complete PR in the review queue.
I take @austinlparker's joke at least half seriously, and suggest that we separate issues between logo and domain updates. For details, see #3647 (comment).
I'll be OOO so I'll let @open-telemetry/docs-maintainers decide what to do while we're waiting for the Docsy update (at least mark the PR as draft). IMHO, this isn't urgent.
Here's the update of Docsy (and FA): Once it lands, rebase and feel free to clean up this PR to include only the changes that we've agreed to and that @svrnm mentioned. Thanks! |
…till reference Twitter.
…till reference Twitter.
55cdad3
to
52a87c7
Compare
@svrnm All set! |
/fix:format |
You triggered fix:format action run at /~https://github.com/open-telemetry/opentelemetry.io/actions/runs/7259608975 |
🎉 thank you @nmummau |
Originally this PR was to handle issue #3647, but then I realized submodules needed updated to get the new logo (
@fortawesome/fontawesome-free
had to be updated in google/docsy and then the cncf/docsys fork had to be updated)Instead of this PR handling any of those dependencies, this change was put on hold until those updates took place (which they now have).
See #3665 which broke up the "Twitter-to-X updates" and this handles one part of that issue.