Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prometheus host and port config options explicit #4147

Merged
merged 4 commits into from
Jul 23, 2024
Merged

Make prometheus host and port config options explicit #4147

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41bc1ad
Make prometheus host and port config options explicit
jack-berg Jul 15, 2024
d4f2f03
Add changelog entry
jack-berg Jul 15, 2024
21eb11a
Merge branch 'main' into prometheus-exporter-host-and-port
pellared Jul 23, 2024
0ca21f4
Apply suggestions from code review
jack-berg Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions specification/metrics/sdk_exporters/prometheus.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,14 @@ Prometheus exporter.

## Configuration

A Prometheus Exporter SHOULD support a configuration option to set the host
metrics are served on. The option MAY be named `host`, and MUST be `localhost`
jack-berg marked this conversation as resolved.
Show resolved Hide resolved
by default.

A Prometheus Exporter SHOULD support a configuration option to set the port
metrics are served on. The option MAY be named `port`, and MUST be `9464` by
jack-berg marked this conversation as resolved.
Show resolved Hide resolved
default.

A Prometheus Exporter MAY offer configuration to add resource attributes as metric attributes.
By default, it MUST NOT add any resource attributes as metric attributes.
The configuration SHOULD allow the user to select which resource attributes to copy (e.g.
Expand Down
Loading