[configuration] Add example using hexadecimal notation #3975
Conversation
|
cc @open-telemetry/configuration-maintainers |
|
Also cc @evan-bradley @astencel-sumo @swiatekm-sumo since we discussed something related at Kubecon, in case you want to take a look :) |
Co-authored-by: Robert Pająk <pellared@hotmail.com>
|
Since the behavior here depends on supporting the core schema I am going to mark this as draft until we decide on #3973 |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
Will ask for this to be reopened once we resolve #3973 |
|
@jack-berg would you be able to reopen this? I don't have permissions and want to retake this after #3973 has been merged |
|
This just exemplifies what should happen now that we have #3973: |
There was a problem hiding this comment.
Seems good to me. I updated the java implementation to reflect this: open-telemetry/opentelemetry-java#6436
…y#3975) Updates open-telemetry#3959 ## Changes Adds example for using an integer in hexadecimal notation. The intention is to show the difference when quoting vs not quoting and make explicit that quoting means keeping the original representation (we already have the `true` example but this one has two different representations). I think this is already implied by the text so this is only a change in the example. * [x] Related issues open-telemetry#3959, part of open-telemetry#3963 --------- Co-authored-by: Robert Pająk <pellared@hotmail.com>
Updates #3959
Changes
Adds example for using an integer in hexadecimal notation. The intention is to show the difference when quoting vs not quoting and make explicit that quoting means keeping the original representation (we already have the
trueexample but this one has two different representations).I think this is already implied by the text so this is only a change in the example.