Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine SDK MeterProvider configuration section #3522

Merged
merged 11 commits into from
Jun 14, 2023
Merged

Refine SDK MeterProvider configuration section #3522

Changes from 10 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
6f360b1
Refine SDK MeterProvider configuration section
pellared May 31, 2023
2a23305
Update sdk.md
pellared May 31, 2023
a96269f
Update sdk.md
pellared May 31, 2023
baf7e8e
Update sdk.md
pellared May 31, 2023
56880d6
Update sdk.md
pellared May 31, 2023
156f6c8
Update sdk.md
pellared May 31, 2023
cca1a11
Merge branch 'main' into patch-4
pellared Jun 2, 2023
fc2e1a2
Merge branch 'main' into patch-4
pellared Jun 7, 2023
03c0a64
Merge branch 'main' into patch-4
pellared Jun 8, 2023
b3bb68b
Merge branch 'main' into patch-4
arminru Jun 14, 2023
66a4491
Update CHANGELOG.md
arminru Jun 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions specification/metrics/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ linkTitle: SDK
- [MeterProvider](#meterprovider)
* [MeterProvider Creation](#meterprovider-creation)
* [Meter Creation](#meter-creation)
* [Configuration](#configuration)
* [Shutdown](#shutdown)
* [ForceFlush](#forceflush)
* [View](#view)
Expand Down Expand Up @@ -112,11 +113,12 @@ When a Schema URL is passed as an argument when creating a `Meter` the emitted
telemetry for that `Meter` MUST be associated with the Schema URL, provided
that the emitted data format is capable of representing such association.

Configuration (i.e., [MetricExporters](#metricexporter),
[MetricReaders](#metricreader) and [Views](#view)) MUST be managed solely by the
`MeterProvider` and the SDK MUST provide a way to configure all options that are
implemented by the SDK. This MAY be done at the time of MeterProvider creation
if appropriate.
### Configuration

Configuration (i.e. [MetricExporters](#metricexporter),
[MetricReaders](#metricreader) and [Views](#view)) MUST be owned by the
`MeterProvider`. The configuration MAY be applied at the time of `MeterProvider`
creation if appropriate.

The `MeterProvider` MAY provide methods to update the configuration. If
configuration is updated (e.g., adding a `MetricReader`), the updated
Expand Down