Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify seconds unit for measuring durations #3388

Merged
merged 4 commits into from
Apr 14, 2023
Merged

Specify seconds unit for measuring durations #3388

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f34f4df
Specify seconds unit for measuring durations
jack-berg Apr 12, 2023
2ebddbb
Add changelog entry
jack-berg Apr 12, 2023
f7484a7
Merge branch 'main' into record-durations-in-seconds
trask Apr 14, 2023
75a90ce
Merge branch 'main' into record-durations-in-seconds
reyang Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,8 @@ release.
- Add clarification that UCUM c/s variant applies to all units other than `1` and
those using [annotations](https://ucum.org/ucum.html#para-curly).
([#3393](/~https://github.com/open-telemetry/opentelemetry-specification/pull/3393))
- Specify that seconds should be used for measuring durations.
([#3388](/~https://github.com/open-telemetry/opentelemetry-specification/pull/3388))

### Compatibility

Expand Down
1 change: 1 addition & 0 deletions specification/metrics/semantic_conventions/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,6 +194,7 @@ use `{packet}`, `{error}`, `{fault}`, etc.
For example, "Cel" for the unit with full name "degree Celsius".
- Instruments SHOULD use non-prefixed units (i.e. `By` instead of `MiBy`)
unless there is good technical reason to not do so.
- When instruments are measuring durations, seconds (i.e. `s`) SHOULD be used.

### Instrument Types

Expand Down