Add OpenCensus metric bridge specification #2732
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dashpole
force-pushed
the
opencensus_bridge
branch
from
f1e5146 to
393fa1d
Compare
7 tasks
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
jsuereth
approved these changes
Aug 29, 2022
reyang
approved these changes
Sep 2, 2022
dashpole
force-pushed
the
opencensus_bridge
branch
from
4f9e105 to
f192737
Compare
jack-berg
reviewed
Sep 8, 2022
| > conventions, All API surface area should map to the closest relevant OTel | ||
| > API and no SDK usage of OpenCensus will be compatible. | ||
| OpenTelemetry will provide an OpenCensus-Metrics-Shim component which | ||
| implements the OpenTelemetry MetricProducer interface. When Produce() is |
There was a problem hiding this comment.
#nit: Add link to MetricProducer interface when available.
dashpole
force-pushed
the
opencensus_bridge
branch
from
f192737 to
b25a36e
Compare
dashpole
commented
Sep 14, 2022
jack-berg
approved these changes
Sep 14, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
dashpole
force-pushed
the
opencensus_bridge
branch
from
b25a36e to
b398528
Compare
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
I'll reopen after we decide on #2838 |
|
This PR can be reopened now that #2951 is merged |
|
Looks like we need a new one:
|
|
Ah, darn. Reopened as #2979 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1175
Related to #2730
Depends on #2722. Do not merge until after that PR.
Changes
Specify that OpenCensus metric bridges implement the MetricProducer interface, and describe non-trivial transformations involved.
This follows the path taken by the java opencensus-shim.