-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add container runtime to container conventions #1482
Conversation
This allows users to identify the engine and possible issues with the runtime when debugging.
Addressed the feedback, please take a look. |
Actually it would probably be better to use an enum like we did elsewhere, for example here:
opentelemetry-specification/specification/resource/semantic_conventions/cloud.md Lines 22 to 28 in 7033091
This will allow constant classes or helpers generated from the YAML definitions to provide constants for these well-known engines in order to ensure we always get the same values. If users have to provide the string values themselves, we will probably get |
This allows users to identify the engine and possible issues with the runtime when debugging.