Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split OTEL_EXPORTER to OTEL_TRACE_EXPORTER and OTEL_METRICS_EXPORTER #1318

Merged
merged 8 commits into from
Jan 13, 2021
Merged

Split OTEL_EXPORTER to OTEL_TRACE_EXPORTER and OTEL_METRICS_EXPORTER #1318

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
39b03ed
Rename OTEL_EXPORTER to OTEL_EXPORTERS
Jan 5, 2021
d4502d6
Split exporter variables
Jan 6, 2021
07faed8
Update compliance matrix
Jan 6, 2021
cf3b6bf
Clean
Jan 8, 2021
79007ed
Merge branch 'master' of github.com:open-telemetry/opentelemetry-spec…
Jan 9, 2021
fe8215f
Changelog
Jan 9, 2021
3366da2
Merge branch 'master' of github.com:open-telemetry/opentelemetry-spec…
Jan 12, 2021
df105be
Update spec-compliance-matrix.md
Jan 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added exporters
View file
Open in desktop
Empty file.
3 changes: 2 additions & 1 deletion spec-compliance-matrix.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,8 @@ status of the feature is not known.
|OTEL_EXPORTER_OTLP_* | | + | | + | + | - | - | | - | - | - |
|OTEL_EXPORTER_JAEGER_* | | + | | + | + | - | - | + | - | - | - |
|OTEL_EXPORTER_ZIPKIN_* | | + | | + | | - | - | | - | - | - |
|OTEL_EXPORTER | | - | | + | | | | | | - | - |
|OTEL_TRACE_EXPORTER | | - | | - | | | | | | - | - |
|OTEL_METRICS_EXPORTERS | | - | | - | | | | | | - | - |
anuraaga marked this conversation as resolved.
Show resolved Hide resolved
|OTEL_SPAN_ATTRIBUTE_COUNT_LIMIT | | + | | + | + | | | | | - | - |
|OTEL_SPAN_EVENT_COUNT_LIMIT | | + | | + | + | | | | | - | - |
|OTEL_SPAN_LINK_COUNT_LIMIT | | + | | + | + | | | | | - | - |
Expand Down
17 changes: 14 additions & 3 deletions specification/sdk-environment-variables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,13 +75,24 @@ See [OpenTelemetry Protocol Exporter Configuration Options](./protocol/exporter.

## Exporter Selection

We define environment variables for setting a single exporter per signal. SDKs SHOULD provide a means to
set multiple exporters for a signal programmatically.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused. First it says setting "a single exporter". Then it says set "multiple exporters". Is it "single" or "multiple"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The difference is whether it's an environment variable or programmatically. Not sure how to reword it to be less confusing but let me know if you have an idea :) Or if this point isn't helpful (doc is about env variables) I can delete it too.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not helpful here - SDK API requirements should be in one place.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it - removed


| Name | Description | Default |
| ------------- | ---------------------------------------------------------------------------- | ------- |
| OTEL_EXPORTER | Exporter to be used, can be a comma-separated list to use multiple exporters | "otlp" |
| OTEL_TRACE_EXPORTER | Trace exporter to be used | "otlp" |
| OTEL_METRICS_EXPORTER | Metrics exporter to be used | "otlp" |

Known values for OTEL_TRACE_EXPORTER are:

- `"otlp"`: [OTLP](./protocol/otlp.md)
- `"jaeger"`: [Jaeger gRPC](https://www.jaegertracing.io/docs/1.21/apis/#protobuf-via-grpc-stable)
- `"zipkin"`: [Zipkin](https://zipkin.io/zipkin-api/) (Defaults to [protobuf](/~https://github.com/openzipkin/zipkin-api/blob/master/zipkin.proto) format)

Known values for OTEL_EXPORTER are: "otlp", "jaeger", "zipkin", "prometheus", "otlp_span", "otlp_metric".
Known values for OTEL_METRICS_EXPORTER are:

Note: "otlp" is equivalent to "otlp_span,otlp_metric".
- `"otlp"`: [OTLP](./protocol/otlp.md)
- `"prometheus"`: [Prometheus](/~https://github.com/prometheus/docs/blob/master/content/docs/instrumenting/exposition_formats.md)

## Language Specific Environment Variables

Expand Down