Skip to content

Commit

Permalink
update based on review feedback
Browse files Browse the repository at this point in the history
  • Loading branch information
reyang committed Nov 16, 2021
1 parent d55b65b commit a19943d
Showing 1 changed file with 3 additions and 10 deletions.
13 changes: 3 additions & 10 deletions specification/metrics/sdk_exporters/prometheus.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,21 +11,14 @@ Pushgateway](/~https://github.com/prometheus/pushgateway).
Prometheus Exporter SHOULD support [Pull mode](../sdk.md#pull-metric-exporter),
if possible.

Prometheus Exporter MAY support [Push mode](../sdk.md#push-metric-exporter), if
there is a need to support short-lived applications (e.g. short-lived
service-level batch jobs, JavaScript applications running inside web browsers,
etc.).
Support for [Push mode](../sdk.md#push-metric-exporter) is out of scope for the
initial release.

Prometheus Exporter MUST support version `0.0.4` of the [Text-based
format](/~https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#text-based-format).

Prometheus Exporter SHOULD only support [Cumulative
Temporality](../datamodel.md#temporality). Attempt to change the [Aggregation
Temporality](../datamodel.md#temporality) to
[Delta](../datamodel.md#temporality) SHOULD be treated as an error. It is
unspecified _how_ the this error should be handled (e.g. it could fail fast
during the exporter configuration time). Please refer to [Error handling in
OpenTelemetry](../../error-handling.md) for the general guidance.
Temporality](../datamodel.md#temporality).

Prometheus Exporter MAY support [OpenMetrics Text
Format](/~https://github.com/prometheus/docs/blob/main/content/docs/instrumenting/exposition_formats.md#openmetrics-text-format),
Expand Down

0 comments on commit a19943d

Please sign in to comment.