Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Metrics SDK] Reduce the scope of write lock #2489

Closed
wants to merge 2 commits into from

Merge branch 'main' into utpilla/Optimize-Metrics-ValueMap

da63650
Select commit
Loading
Failed to load commit list.
Closed

[Metrics SDK] Reduce the scope of write lock #2489

Merge branch 'main' into utpilla/Optimize-Metrics-ValueMap
da63650
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 1, 2025 in 0s

77.9% (-0.1%) compared to 42b4f2f

View this Pull Request on Codecov

77.9% (-0.1%) compared to 42b4f2f

Details

Codecov Report

Attention: Patch coverage is 80.64516% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.9%. Comparing base (42b4f2f) to head (da63650).

Files with missing lines Patch % Lines
opentelemetry-sdk/src/metrics/internal/mod.rs 80.6% 6 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##            main   #2489     +/-   ##
=======================================
- Coverage   77.9%   77.9%   -0.1%     
=======================================
  Files        123     123             
  Lines      22925   22947     +22     
=======================================
+ Hits       17870   17886     +16     
- Misses      5055    5061      +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov