Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add mTLS for metrics exporter #1712

Merged
merged 8 commits into from
Oct 11, 2024
Merged

fix: add mTLS for metrics exporter #1712

merged 8 commits into from
Oct 11, 2024

Conversation

xuan-cao-swi
Copy link
Contributor

Closes #1688

kaylareopelle
kaylareopelle requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@kaylareopelle kaylareopelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, Xuan! One small thing with the tests.

exporter/otlp-metrics/test/opentelemetry/exporter/otlp/metrics_exporter_test.rb Outdated Show resolved Hide resolved
@kaylareopelle kaylareopelle mentioned this pull request Sep 4, 2024
Closed
@xuan-cao-swi @bdewater
Update exporter/otlp-metrics/README.md
dbf0e96 
Co-authored-by: Bart de Water <496367+bdewater@users.noreply.github.com>
mwear
mwear approved these changes Sep 13, 2024
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you fix the conflicts?

@mwear mwear merged commit 75502b6 into open-telemetry:main Oct 11, 2024
62 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bdewater bdewater bdewater left review comments

@kaylareopelle kaylareopelle kaylareopelle approved these changes

@mwear mwear mwear approved these changes

@fbogsany fbogsany Awaiting requested review from fbogsany fbogsany is a code owner

@robertlaurin robertlaurin Awaiting requested review from robertlaurin robertlaurin is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Assignees
No one assigned
Labels
metrics
Projects
Ruby - Metrics
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add mutual TLS support to otlp metrics exporter
4 participants
@xuan-cao-swi @bdewater @mwear @kaylareopelle