Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ruby 3.0 compatibility for generate_r #1538

Merged
merged 3 commits into from
Nov 2, 2023
Merged

fix: Ruby 3.0 compatibility for generate_r #1538

merged 3 commits into from
Nov 2, 2023

Conversation

fbogsany
Copy link
Contributor

@fbogsany fbogsany commented Nov 2, 2023

Fixes Ruby 3.0 compatibility for generate_r accidentally added in #1522 and pointed out by @casperisfine in #1522 (review)

casperisfine
casperisfine approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@casperisfine casperisfine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

simi
simi reviewed Nov 2, 2023
View reviewed changes
Copy link
Contributor

@simi simi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀 I'll check on CI failure, seems not related to this. Would you mind to open different PR for CI change? I can continue in there.

@fbogsany
Copy link
Contributor Author

fbogsany commented Nov 2, 2023

👀 I'll check on CI failure, seems not related to this. Would you mind to open different PR for CI change? I can continue in there.

CI failure is fixed. I incorrectly assumed the directory name matched the gemspec name.

@fbogsany fbogsany merged commit 39a7e7f into main Nov 2, 2023
51 checks passed
@robertlaurin robertlaurin deleted the ruby3.0-compat-for-generate_r branch November 2, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertlaurin robertlaurin robertlaurin approved these changes

@casperisfine casperisfine casperisfine approved these changes

@simi simi simi approved these changes

@mwear mwear Awaiting requested review from mwear mwear is a code owner

@dazuma dazuma Awaiting requested review from dazuma dazuma is a code owner

@ericmustin ericmustin Awaiting requested review from ericmustin ericmustin is a code owner

@arielvalentin arielvalentin Awaiting requested review from arielvalentin arielvalentin is a code owner

@ahayworth ahayworth Awaiting requested review from ahayworth ahayworth is a code owner

@plantfansam plantfansam Awaiting requested review from plantfansam plantfansam is a code owner

@robbkidd robbkidd Awaiting requested review from robbkidd robbkidd is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fbogsany @simi @casperisfine @robertlaurin