Assert correct elements are removed from hashes larger than limit.

[ptolts]

Adds missing test coverage for Tracestates larger than 32.

[linux-foundation-easycla]

• ❌ - login: @ptolts / name: Philip Tolton . The commit (746f3f2) is not authorized under a signed CLA. Please click here to be authorized. For further assistance with EasyCLA, please submit a support request ticket.

[fbogsany]

This is technically incorrect. From #1533 (comment)

Followup: the W3C trace-context spec states:

In a situation where tracestate needs to be truncated due to size limitations, the vendor MUST truncate whole entries. Entries larger than 128 characters long SHOULD be removed first. Then entries SHOULD be removed starting from the end of tracestate. Note that other truncation strategies like safe list entries, blocked list entries, or size-based truncation MAY be used, but are highly discouraged. Those strategies decrease the interoperability of various tracing vendors.

Our implementation is wrong and we should remove entries from the end rather than the start (and, of course, we should remove entries > 128 characters first).

[ptolts]

I'll close, thanks Bogs.

[fbogsany]

I'll close, thanks Bogs.

😞 I was kinda hoping you'd fix the test and then we could fix the implementation 😄

[fbogsany]

@ptolts could you please click the link in #1535 (comment) to authorize the CLA?

[fbogsany]

Suggested change

	_(output_hash).must_equal(input_hash.drop(1).to_h)
	_(output_hash).must_equal(input_hash.first(32).to_h)

[kaylareopelle]

Hi, @ptolts! Checking in on this PR. Would you be open to signing the CLA?

[github-actions]

👋 This pull request has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this pull request will be closed eventually by the stale bot